| Message ID | 1541042683-18433-1-git-send-email-xu.rong@zte.com.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev] ovn-controller: function ofctrl_inject_pkt() with wrong parameter | expand |
Bleep bloop. Greetings xurong00037997, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author xurong00037997 <xu.rong@zte.com.cn> needs to sign off. Lines checked: 26, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@bytheb.org Thanks, 0-day Robot
The patch looks good, but you need to add a sign-off. See Documentation/internals/contributing/submitting-patches.rst, the "Tags" section for details. On 10/31/2018 11:24 PM, xurong00037997 wrote: > --- > ovn/controller/ovn-controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c > index 2b2779a..dd481b6 100644 > --- a/ovn/controller/ovn-controller.c > +++ b/ovn/controller/ovn-controller.c > @@ -792,7 +792,7 @@ main(int argc, char *argv[]) > > if (pending_pkt.conn) { > char *error = ofctrl_inject_pkt(br_int, pending_pkt.flow_s, > - &port_groups, &addr_sets); > + &addr_sets, &port_groups); > if (error) { > unixctl_command_reply_error(pending_pkt.conn, error); > free(error); >
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 2b2779a..dd481b6 100644 --- a/ovn/controller/ovn-controller.c +++ b/ovn/controller/ovn-controller.c @@ -792,7 +792,7 @@ main(int argc, char *argv[]) if (pending_pkt.conn) { char *error = ofctrl_inject_pkt(br_int, pending_pkt.flow_s, - &port_groups, &addr_sets); + &addr_sets, &port_groups); if (error) { unixctl_command_reply_error(pending_pkt.conn, error); free(error);