diff mbox series

[ovs-dev] dpctl: Fix memory leak in dp_exists().

Message ID 1535370775-11832-1-git-send-email-wangyunjian@huawei.com
State Accepted
Headers show
Series [ovs-dev] dpctl: Fix memory leak in dp_exists(). | expand

Commit Message

Yunjian Wang Aug. 27, 2018, 11:52 a.m. UTC 
From: Yunjian Wang <wangyunjian@huawei.com>

Fixes: ffdcd110fa62 ("dpctl: Make opt_dpif_open() more general.")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 lib/dpctl.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ben Pfaff Aug. 27, 2018, 4:07 p.m. UTC | #1 
On Mon, Aug 27, 2018 at 07:52:55PM +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> Fixes: ffdcd110fa62 ("dpctl: Make opt_dpif_open() more general.")
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Thanks, applied to master and branch-2.10.
Darrell Ball Aug. 27, 2018, 10:21 p.m. UTC | #2 
oops; good catch.

On 8/27/18, 9:08 AM, "ovs-dev-bounces@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-bounces@openvswitch.org on behalf of blp@ovn.org> wrote:

    On Mon, Aug 27, 2018 at 07:52:55PM +0800, wangyunjian wrote:
    > From: Yunjian Wang <wangyunjian@huawei.com>
    > 
    > Fixes: ffdcd110fa62 ("dpctl: Make opt_dpif_open() more general.")
    > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
    
    Thanks, applied to master and branch-2.10.
    _______________________________________________
    dev mailing list
    dev@openvswitch.org
    https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=02%7C01%7Cdball%40vmware.com%7Cac75f6bb5b48428e881708d60c37475a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636709828951186926&amp;sdata=JEDAZmr1hD%2FZAcE2F%2F49GjrxxQ6SdaDiBSdsWS%2FhSgU%3D&amp;reserved=0
diff mbox series

Patch

diff --git a/lib/dpctl.c b/lib/dpctl.c
index 743944d..2f8498f 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -202,6 +202,8 @@  dp_exists(const char *queried_dp)
 
     sset_destroy(&dpif_names);
     sset_destroy(&dpif_types);
+    free(queried_name);
+    free(queried_type);
     return found;
 }