Message ID | 1534145820-119903-2-git-send-email-hzhou8@ebay.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jnhrqX1R"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41pndT4870z9sBD for <incoming@patchwork.ozlabs.org>; Mon, 13 Aug 2018 17:38:05 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 0F376C74; Mon, 13 Aug 2018 07:37:34 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CD638A59 for <dev@openvswitch.org>; Mon, 13 Aug 2018 07:37:32 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 936392D4 for <dev@openvswitch.org>; Mon, 13 Aug 2018 07:37:32 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id u24-v6so7286331pfn.13 for <dev@openvswitch.org>; Mon, 13 Aug 2018 00:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=43RQF4wb5guKu82Dup2HvEmJ8Drl2SWixK3SBZFJZwM=; b=jnhrqX1RvptENHPMuB8dOK5qsZjpAv37LIQAmKAEJRHyM3ofSBcJ0NQIhqvxKzyGmN eWMLH5i6wew8xaxD8EJolIV+3a8HG75NpNcmEnUS0EpmKJerAgBV3qkwrCy5EkVJCZLg reQOKQ1PrGLjKG4qgo0X06NV2ki9ilNJbw0c0BQ2hXp+4Q2NmgbPH2VwL7jt0Q/CTAzS /JB4VcUBdTFjg09nGK8jB80fgEokvJcs/tqOUdI6e6SvGtOnMjbwBeQRf+ljhCx7/2B5 b/U6wkzJbZHwOzBkOwSsdFmUfvh67eiLgmkeSRqGWVm44GMZlWDF8TqGUIxGTZc0XLoH fJVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=43RQF4wb5guKu82Dup2HvEmJ8Drl2SWixK3SBZFJZwM=; b=dOGl6N1yodAfDpknIIWuJCgMa0xdyBu32+QdS2i9hQt3MBSrOgL3/reAHOmjM8XBp6 wj10grRPN4st0fS2gvAtYlvNZsqIh1nyaKL9ElL0she5UNYQOkwLTxhI3dqkZ28DPnMl KXgTpk/c7hFpvwFJFMEO9X8A/NrXP63ABzWUmMlPXmiujcBlSM+izkzpS9YKtozboLKl aFXLqKXVeCONkvdcVnA28YIbOnw2baNLRUdlSgY0xWbcn2TMyRbvKcmESyPoCV3pbW1s k5ATp2Kr0ZBjJ6xHF6pUASCizhg1tHlrqD+sx64cjwQRRbJd2Ae8iRg9qNJ902UAr9J7 mWng== X-Gm-Message-State: AOUpUlF8GoMY6tMeP/syNlkMcXFeP78DESQBQzEOmjKZek+8Li/hhubq IxJiPcZ4KPwGqyb1iyWknrp0V9uM X-Google-Smtp-Source: AA+uWPw4je2ejHWC66cLOzwc6nE6kX+D8yFh1A/GbsM9Ka4ok2wkuTW+7WPEt2mgKv7rCUHhCLNZaw== X-Received: by 2002:a63:6b86:: with SMTP id g128-v6mr16237900pgc.344.1534145852042; Mon, 13 Aug 2018 00:37:32 -0700 (PDT) Received: from localhost.localdomain.localdomain (c-73-162-150-77.hsd1.ca.comcast.net. [73.162.150.77]) by smtp.gmail.com with ESMTPSA id o10-v6sm30456465pfk.76.2018.08.13.00.37.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Aug 2018 00:37:31 -0700 (PDT) From: Han Zhou <zhouhan@gmail.com> X-Google-Original-From: Han Zhou <hzhou8@ebay.com> To: dev@openvswitch.org Date: Mon, 13 Aug 2018 00:36:41 -0700 Message-Id: <1534145820-119903-2-git-send-email-hzhou8@ebay.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1534145820-119903-1-git-send-email-hzhou8@ebay.com> References: <1534145820-119903-1-git-send-email-hzhou8@ebay.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v4 01/20] ovsdb-idl.c: Remove a misleading comment for change tracking. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
Series |
ovn-controller incremental processing
|
expand
|
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 40c29cb..b0ebe8c 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -2834,9 +2834,7 @@ ovsdb_idl_row_clear_arcs(struct ovsdb_idl_row *row, bool destroy_dsts) struct ovsdb_idl_arc *arc, *next; /* Delete all forward arcs. If 'destroy_dsts', destroy any orphaned rows - * that this causes to be unreferenced, if tracking is not enabled. - * If tracking is enabled, orphaned nodes are removed from hmap but not - * freed. + * that this causes to be unreferenced. */ LIST_FOR_EACH_SAFE (arc, next, src_node, &row->src_arcs) { ovs_list_remove(&arc->dst_node);
The comment was added when the feature was introduced but what it described is not what is implemented, probably because of revisions after code reviews. Signed-off-by: Han Zhou <hzhou8@ebay.com> --- lib/ovsdb-idl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)