From patchwork Mon Jan 22 16:24:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 864303 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="eMMzcxZg"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zQGwp2BGGz9s7F for ; Tue, 23 Jan 2018 03:24:42 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id ECC81F2C; Mon, 22 Jan 2018 16:24:38 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 88BC2EF9 for ; Mon, 22 Jan 2018 16:24:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A67DE149 for ; Mon, 22 Jan 2018 16:24:36 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180122162434euoutp02a54e91393e3b5a4b5671846a3a00786f~MLnmMIbzC3106731067euoutp02O; Mon, 22 Jan 2018 16:24:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180122162434euoutp02a54e91393e3b5a4b5671846a3a00786f~MLnmMIbzC3106731067euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1516638274; bh=59y3OAj/KhcCloI5RuLzjgtbrmMSKH6uuvz3zMiOC6c=; h=From:To:Cc:Subject:Date:References:From; b=eMMzcxZgBc5IUaISnehdgsus6Nj214Tbngq/sTBMbeC/na28e+m83JJ8jYSYCobtj bi2+QU2Qh26+Is4coDXyB/ZceQiOPoT86u63R0Ll2isEERIgEBOGE0woC5Nazq692B ZxSMSkmo3/s8QbVh2CDO86Impgw3ttxZqom2t+3Q= Received: from eusmges4.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180122162433eucas1p2acdd91eae28ea7e9708947812b6277f4~MLnleHiN00596205962eucas1p2u; Mon, 22 Jan 2018 16:24:33 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges4.samsung.com (EUCPMTA) with SMTP id 6A.3F.30163.140166A5; Mon, 22 Jan 2018 16:24:33 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180122162432eucas1p1d6e75eb7b3307953150d767d89d2939e~MLnk5DSt01985019850eucas1p1J; Mon, 22 Jan 2018 16:24:32 +0000 (GMT) X-AuditID: cbfec7f4-f790c6d0000075d3-ef-5a6610419abc Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E3.F7.20118.040166A5; Mon, 22 Jan 2018 16:24:32 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P2Y00BURTKS7T20@eusync3.samsung.com>; Mon, 22 Jan 2018 16:24:32 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Mon, 22 Jan 2018 19:24:26 +0300 Message-id: <1516638266-17669-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsWy7djP87qOAmlRBl+7WCxeTW5gtJj2+Ta7 xZX2n+wWGx+eZbV413GD0WLup+eMDmwei/e8ZPJ4dvM/o8fzaz0sHn1bVjEGsERx2aSk5mSW pRbp2yVwZbQ82s1a8Iql4sfESWwNjA+Zuxg5OCQETCQuP4zvYuQEMsUkLtxbz9bFyMUhJLCU UeLZ1C+MIAkhgc+MEnvucsHU7/vNDlGzjFFi37ldUA3NTBJPr89lAWlgE9CROLX6CFiziIC0 xOveN6wgRcwC+xklXr9eCVYkLBAkce3GBDCbRUBVYvv5b+wgNq+Am8TJf3+ZIU6Sk7h5rpMZ pFlC4C2rxJcX6xkhEi4SX2evhbKFJV4d38IOYctIXJ7czQLR0Mwo0bDqEiOEM4FR4kvzciaI KnuJUzevgtnMAnwSk7ZNhwYGr0RHmxBEiYfE+QsPoBY4SnROPw0Ni1iJiwdfMk1glFrAyLCK USS1tDg3PbXYRK84Mbe4NC9dLzk/dxMjMP5O/zv+ZQfj4mNWhxgFOBiVeHgrmNOihFgTy4or cw8xSnAwK4nwpq1IjRLiTUmsrEotyo8vKs1JLT7EKM3BoiTOaxvVFikkkJ5YkpqdmlqQWgST ZeLglGpgjAsUj1SxF3rGl90hLMD0RNpERLCwuyB++1qJZ1Ok1XtCm8JOTL2tFVQQ9iNmn6ZM UtjSx0ZujXOiKz7ah9jafZ54zErDeV/dyxYLzvcWtgukii5YLOvc5O72/avkrYnWZYUtE5T+ hYqdKIl4yuso4ly2WsNqJvPrd25SlRM8OM77cJgIcyqxFGckGmoxFxUnAgDVZY/nuwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEJMWRmVeSWpSXmKPExsVy+t/xq7oOAmlRBtcvaVq8mtzAaDHt8212 iyvtP9ktNj48y2rxruMGo8XcT88ZHdg8Fu95yeTx7OZ/Ro/n13pYPPq2rGIMYInisklJzcks Sy3St0vgymh5tJu14BVLxY+Jk9gaGB8ydzFycEgImEjs+83excgJZIpJXLi3nq2LkYtDSGAJ o8SjN8+ZIJxWJonLjx+ygVSxCehInFp9hBHEFhGQlnjd+4YVpIhZYD+jxN0jX5lBEsICARJt y6axgtgsAqoS289/A1vBK+AmcfLfX2aIdXISN891Mk9g5F7AyLCKUSS1tDg3PbfYSK84Mbe4 NC9dLzk/dxMjMCS2Hfu5ZQdj17vgQ4wCHIxKPLyKjGlRQqyJZcWVuYcYJTiYlUR401akRgnx piRWVqUW5ccXleakFh9ilOZgURLn7d2zOlJIID2xJDU7NbUgtQgmy8TBKdXAuHWF6Nrfe6de ZMl4UbvOxVX7hnq2yG117XK1ruuCeuWTqi2287H1Wrm9/xKiVX917oUjbDMdKycEvXkTcnq9 7uuz+249vqvJtFeN9eZu64uNPt0HH89K4Zk8wblun3Z8SGCenmuhRa3s3tcNp5J+LlC8mPMr 3fqAMsesPL7zS/+eZMvfdf1aiBJLcUaioRZzUXEiAGcS9eoFAgAA X-CMS-MailID: 20180122162432eucas1p1d6e75eb7b3307953150d767d89d2939e X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180122162432eucas1p1d6e75eb7b3307953150d767d89d2939e X-RootMTR: 20180122162432eucas1p1d6e75eb7b3307953150d767d89d2939e References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Heetae Ahn Subject: [ovs-dev] [PATCH] netdev-dpdk: Fix memory leak in netdev_dpdk_get_custom_stats(). X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org CC: Michal Weglicki Fixes: 971f4b394c6e ("netdev: Custom statistics.") Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index ac2e38e..a37c8df 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2359,6 +2359,8 @@ netdev_dpdk_get_custom_stats(const struct netdev *netdev, * reconfigured */ netdev_dpdk_clear_xstats(dev); } + + free(values); } ovs_mutex_unlock(&dev->mutex);