| Message ID | 1509494621-26976-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,PATCHv2] acinclude: Fix SKB_GSO_UDP check. | expand |
On Tue, Oct 31, 2017 at 05:03:41PM -0700, William Tu wrote: > The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP. > However, it falsely returns yes because grep matches SKB_GSO_UDP_TUNNEL. > Thus, add space character '[:space:]' before and after it. > > Fixes: ad283644f0e4 ("acinclude: Check for SKB_GSO_UDP") > Signed-off-by: William Tu <u9012063@gmail.com> > Cc: Greg Rose <gvrose8192@gmail.com> > --- > v1->v2 > remove using "grep -w" since -w is not POSIX Applied, thanks!
diff --git a/acinclude.m4 b/acinclude.m4 index 89f88ca8de75..c653a75a356b 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -768,7 +768,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ OVS_GREP_IFELSE([$KSRC/include/net/netfilter/nf_conntrack_helper.h], [nf_conntrack_helper_put], [OVS_DEFINE(HAVE_NF_CONNTRACK_HELPER_PUT)]) - OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],[SKB_GSO_UDP], + OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],[[[[:space:]]]SKB_GSO_UDP[[[:space:]]]], [OVS_DEFINE([HAVE_SKB_GSO_UDP])]) OVS_GREP_IFELSE([$KSRC/include/net/dst.h],[DST_NOCACHE], [OVS_DEFINE([HAVE_DST_NOCACHE])])
The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP. However, it falsely returns yes because grep matches SKB_GSO_UDP_TUNNEL. Thus, add space character '[:space:]' before and after it. Fixes: ad283644f0e4 ("acinclude: Check for SKB_GSO_UDP") Signed-off-by: William Tu <u9012063@gmail.com> Cc: Greg Rose <gvrose8192@gmail.com> --- v1->v2 remove using "grep -w" since -w is not POSIX --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)