| Message ID | 1505913181-82547-4-git-send-email-bhanuprakash.bodireddy@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Use packet batch macro and APIs. | expand |
I applied the patch to dpdk_merge here
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=
On 9/20/17, 6:25 AM, "ovs-dev-bounces@openvswitch.org on behalf of Bhanuprakash Bodireddy" <ovs-dev-bounces@openvswitch.org on behalf of bhanuprakash.bodireddy@intel.com> wrote:
Use DP_PACKET_BATCH_FOR_EACH macro in netdev_dpdk_ring_send().
Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
---
lib/netdev-dpdk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 648d719..60ec528 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2942,14 +2942,14 @@ netdev_dpdk_ring_send(struct netdev *netdev, int qid,
bool concurrent_txq)
{
struct netdev_dpdk *dev = netdev_dpdk_cast(netdev);
- unsigned i;
+ struct dp_packet *packet;
/* When using 'dpdkr' and sending to a DPDK ring, we want to ensure that
* the rss hash field is clear. This is because the same mbuf may be
* modified by the consumer of the ring and return into the datapath
* without recalculating the RSS hash. */
- for (i = 0; i < batch->count; i++) {
- dp_packet_mbuf_rss_flag_reset(batch->packets[i]);
+ DP_PACKET_BATCH_FOR_EACH (packet, batch) {
+ dp_packet_mbuf_rss_flag_reset(packet);
}
netdev_dpdk_send__(dev, qid, batch, may_steal, concurrent_txq);
--
2.4.11
_______________________________________________
dev mailing list
dev@openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=oFSnKGsACPJIyvGq0R2xbtCQvcvLPJYfcu1RL9YZSvA&s=-e_0Ge0pq459TomqXYJC5NHmZfcVT_SSYgbz9lr2w2k&e=
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 648d719..60ec528 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2942,14 +2942,14 @@ netdev_dpdk_ring_send(struct netdev *netdev, int qid, bool concurrent_txq) { struct netdev_dpdk *dev = netdev_dpdk_cast(netdev); - unsigned i; + struct dp_packet *packet; /* When using 'dpdkr' and sending to a DPDK ring, we want to ensure that * the rss hash field is clear. This is because the same mbuf may be * modified by the consumer of the ring and return into the datapath * without recalculating the RSS hash. */ - for (i = 0; i < batch->count; i++) { - dp_packet_mbuf_rss_flag_reset(batch->packets[i]); + DP_PACKET_BATCH_FOR_EACH (packet, batch) { + dp_packet_mbuf_rss_flag_reset(packet); } netdev_dpdk_send__(dev, qid, batch, may_steal, concurrent_txq);
Use DP_PACKET_BATCH_FOR_EACH macro in netdev_dpdk_ring_send(). Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)