diff mbox series

[ovs-dev,06/13] netdev-provider: Reorder element in netdev_flow_dump structure.

Message ID 1504893565-110166-7-git-send-email-bhanuprakash.bodireddy@intel.com
State Accepted
Headers show
Series Rearrange structure members for memory efficiency. | expand

Commit Message

Bodireddy, Bhanuprakash Sept. 8, 2017, 5:59 p.m. UTC
By reordering bool in netdev_flow_dump structure, pad bytes can be
reduced.

Before: structure size: 32, sum holes: 4, sum padbytes:7, cachelines:1
After : structure size: 24, sum holes: 3, sum padbytes:0, cachelines:1

Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
---
 lib/netdev-provider.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Nov. 3, 2017, 8:07 p.m. UTC | #1
On Fri, Sep 08, 2017 at 06:59:18PM +0100, Bhanuprakash Bodireddy wrote:
> By reordering bool in netdev_flow_dump structure, pad bytes can be
> reduced.
> 
> Before: structure size: 32, sum holes: 4, sum padbytes:7, cachelines:1
> After : structure size: 24, sum holes: 3, sum padbytes:0, cachelines:1
> 
> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/lib/netdev-provider.h b/lib/netdev-provider.h
index b3c57d5..5d7bd4f 100644
--- a/lib/netdev-provider.h
+++ b/lib/netdev-provider.h
@@ -123,8 +123,8 @@  struct netdev *netdev_rxq_get_netdev(const struct netdev_rxq *);
 struct netdev_flow_dump {
     struct netdev *netdev;
     odp_port_t port;
-    struct nl_dump *nl_dump;
     bool terse;
+    struct nl_dump *nl_dump;
 };
 
 /* Network device class structure, to be defined by each implementation of a