Message ID | 1503630322-29152-1-git-send-email-wangzhike@jd.com |
---|---|
State | Accepted |
Headers | show |
Hi Lawrence
Usually, we label different versions of a patch after the word ‘Patch’; this version is V2.
This looks good to me, but I would like other folks to check out for a day.
Thanks Darrell
On 8/24/17, 8:05 PM, "ovs-dev-bounces@openvswitch.org on behalf of wangzhike" <ovs-dev-bounces@openvswitch.org on behalf of wangzhike@jd.com> wrote:
After ovs-vswitchd reboots, vhost user cient port status is displayed as
Minor typo: cient should be client
LINK DOWN though the traffic is OK.
The problem is that the port may be udpated while the vhost_reconfigured
is false. Then the vhost_reconfigured is updated to true. As a result,
the vhost user status is kept as LINK-DOWN.
Signed-off-by: wangzhike <wangzhike@jd.com>
---
lib/netdev-dpdk.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 1aaf6f7..80415ef 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -3227,7 +3227,11 @@ dpdk_vhost_reconfigure_helper(struct netdev_dpdk *dev)
}
if (netdev_dpdk_get_vid(dev) >= 0) {
- dev->vhost_reconfigured = true;
+ if (dev->vhost_reconfigured == false) {
+ dev->vhost_reconfigured = true;
+ /* Carrier status may need updating. */
+ netdev_change_seq_changed(&dev->up);
+ }
}
return 0;
--
1.8.3.1
_______________________________________________
dev mailing list
dev@openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=kdZ3PVIdn3ViUp6NcxiDEJvMXS04w5UWD2p8CghXxAM&s=pE6z--yDNb53fahFffjHr4iOkM4hJlhuvo-VP76g6pw&e=
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 1aaf6f7..80415ef 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -3227,7 +3227,11 @@ dpdk_vhost_reconfigure_helper(struct netdev_dpdk *dev) } if (netdev_dpdk_get_vid(dev) >= 0) { - dev->vhost_reconfigured = true; + if (dev->vhost_reconfigured == false) { + dev->vhost_reconfigured = true; + /* Carrier status may need updating. */ + netdev_change_seq_changed(&dev->up); + } } return 0;
After ovs-vswitchd reboots, vhost user cient port status is displayed as LINK DOWN though the traffic is OK. The problem is that the port may be udpated while the vhost_reconfigured is false. Then the vhost_reconfigured is updated to true. As a result, the vhost user status is kept as LINK-DOWN. Signed-off-by: wangzhike <wangzhike@jd.com> --- lib/netdev-dpdk.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)