| Message ID | 1500979599-20441-2-git-send-email-i.maximets@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
Thanks. I have pushed the series to master. While applying the patches. I noticed a minor issue and sent a follow up patch at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html Will consider back porting after this patch is reviewed. On Tue, Jul 25, 2017 at 3:46 AM, Ilya Maximets <i.maximets@samsung.com> wrote: > L2 fields are not used in userspace hash action since > commit 4f150744921f ("dpif-netdev: Use miniflow as a flow key."). > In kernel datapath RSS (which is not include L2 by default for > most of the NICs) was used from the beginning. This means that > if recirculation is in use, L2 fields are not used for flow > balancing. > > Fix the documentation accordingly. > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> > --- > > I think, this should be applied to some stable branches too. > > vswitchd/vswitch.xml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index 883ecd8..074535b 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -1569,9 +1569,8 @@ > <dl> > <dt><code>balance-tcp</code></dt> > <dd> > - Balances flows among slaves based on L2, L3, and L4 protocol > - information such as destination MAC address, IP address, and TCP > - port. > + Balances flows among slaves based on L3 and L4 protocol information > + such as IP addresses and TCP/UDP ports. > </dd> > </dl> > > -- > 2.7.4 >
On Tue, Jul 25, 2017 at 11:44 AM, Andy Zhou <azhou@ovn.org> wrote: > Thanks. I have pushed the series to master. > > While applying the patches. I noticed a minor issue and sent a follow > up patch at: > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html > > Will consider back porting after this patch is reviewed. I have back ported the documentation change to branch 2.5. 2.6 and 2.7.
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 883ecd8..074535b 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -1569,9 +1569,8 @@ <dl> <dt><code>balance-tcp</code></dt> <dd> - Balances flows among slaves based on L2, L3, and L4 protocol - information such as destination MAC address, IP address, and TCP - port. + Balances flows among slaves based on L3 and L4 protocol information + such as IP addresses and TCP/UDP ports. </dd> </dl>
L2 fields are not used in userspace hash action since commit 4f150744921f ("dpif-netdev: Use miniflow as a flow key."). In kernel datapath RSS (which is not include L2 by default for most of the NICs) was used from the beginning. This means that if recirculation is in use, L2 fields are not used for flow balancing. Fix the documentation accordingly. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> --- I think, this should be applied to some stable branches too. vswitchd/vswitch.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)