| Message ID | 1500445102-123532-1-git-send-email-jpettit@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On 18 July 2017 at 23:18, Justin Pettit <jpettit@ovn.org> wrote: > This attribute shares space with OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV6, but > it's still worth documenting. > > Signed-off-by: Justin Pettit <jpettit@ovn.org> Strictly speaking I guess that in the nlattr-formatted flow_key it is "mutually exclusive with _CT_ORIG_TUPLE_IPV6", which is bigger and therefore it's not worth counting against the total. Acked-by: Joe Stringer <joe@ovn.org>
> On Jul 19, 2017, at 10:58 AM, Joe Stringer <joe@ovn.org> wrote: > > On 18 July 2017 at 23:18, Justin Pettit <jpettit@ovn.org> wrote: >> This attribute shares space with OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV6, but >> it's still worth documenting. >> >> Signed-off-by: Justin Pettit <jpettit@ovn.org> > > Strictly speaking I guess that in the nlattr-formatted flow_key it is > "mutually exclusive with _CT_ORIG_TUPLE_IPV6", which is bigger and > therefore it's not worth counting against the total. That's true. I was trying to keep it consistent with the Geneve/VxLAN option. but it probably just made it confusing. I changed the comments to indicate that it's "exclusive of". > Acked-by: Joe Stringer <joe@ovn.org> Thanks! --Justin
diff --git a/lib/odp-util.h b/lib/odp-util.h index f49aaa8160d9..9d4e224a747e 100644 --- a/lib/odp-util.h +++ b/lib/odp-util.h @@ -131,6 +131,7 @@ void odp_portno_name_format(const struct hmap *portno_names, * OVS_KEY_ATTR_CT_MARK 4 -- 4 8 * OVS_KEY_ATTR_CT_LABEL 16 -- 4 20 * OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV6 40 -- 4 44 + * OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV4 - -- - - (shared with _CT_ORIG_TUPLE_IPV6) * OVS_KEY_ATTR_ETHERNET 12 -- 4 16 * OVS_KEY_ATTR_ETHERTYPE 2 2 4 8 (outer VLAN ethertype) * OVS_KEY_ATTR_VLAN 2 2 4 8
This attribute shares space with OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV6, but it's still worth documenting. Signed-off-by: Justin Pettit <jpettit@ovn.org> --- lib/odp-util.h | 1 + 1 file changed, 1 insertion(+)