diff mbox

[ovs-dev] acinclude.m4: Avoid echo -n

Message ID 1500131848-70308-1-git-send-email-yamamoto@ovn.org
State Accepted
Headers show

Commit Message

Takashi YAMAMOTO July 15, 2017, 3:17 p.m. UTC 
-n option for echo is not portable.  Use printf instead.
This fixes OSX build on travis-ci.

Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>
---
 acinclude.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff July 15, 2017, 10:45 p.m. UTC | #1 
On Sun, Jul 16, 2017 at 12:17:28AM +0900, YAMAMOTO Takashi wrote:
> -n option for echo is not portable.  Use printf instead.
> This fixes OSX build on travis-ci.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>

Good catch, thank you!

Acked-by: Ben Pfaff <blp@ovn.org>
Takashi YAMAMOTO July 16, 2017, 2:01 a.m. UTC | #2 
On Sun, Jul 16, 2017 at 7:45 AM, Ben Pfaff <blp@ovn.org> wrote:

> On Sun, Jul 16, 2017 at 12:17:28AM +0900, YAMAMOTO Takashi wrote:
> > -n option for echo is not portable.  Use printf instead.
> > This fixes OSX build on travis-ci.
> >
> > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>
>
> Good catch, thank you!
>
> Acked-by: Ben Pfaff <blp@ovn.org>
>

applied to master.
thank you.
diff mbox

Patch

diff --git a/acinclude.m4 b/acinclude.m4
index 48fc856..05c57b8 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -968,7 +968,7 @@  dnl ctags ignores symbols with extras identifiers. This builds a list of
 dnl specially handled identifiers to be ignored.
 AC_DEFUN([OVS_CTAGS_IDENTIFIERS],
     AC_SUBST([OVS_CTAGS_IDENTIFIERS_LIST],
-           [`echo -n '-I "'; sed -n 's/^#define \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' ${srcdir}/include/openvswitch/compiler.h  | tr \\\n ' ' ; echo -n '"'`] ))
+           [`printf '-I "'; sed -n 's/^#define \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' ${srcdir}/include/openvswitch/compiler.h  | tr \\\n ' ' ; printf '"'`] ))
 
 dnl OVS_PTHREAD_SET_NAME
 dnl