diff mbox

[ovs-dev,v5,1/8] ovn: l3ha, add extra check on distributed gateway ports

Message ID 1499965361-32021-1-git-send-email-majopela@redhat.com
State Accepted
Delegated to: Russell Bryant
Headers show

Commit Message

Miguel Angel Ajo July 13, 2017, 5:02 p.m. UTC
Check that removing the options:redirect-chassis in NBDB is
going to remove the cr-${port} in the SBDB.

This is introduced to avoid any regression of this behaviour
on the l3ha series.

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
---
 tests/ovn.at | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Russell Bryant July 15, 2017, 2:07 a.m. UTC | #1
On Thu, Jul 13, 2017 at 1:02 PM, Miguel Angel Ajo <majopela@redhat.com> wrote:
> Check that removing the options:redirect-chassis in NBDB is
> going to remove the cr-${port} in the SBDB.
>
> This is introduced to avoid any regression of this behaviour
> on the l3ha series.
>
> Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
> ---
>  tests/ovn.at | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index efcbd91..f3e6b4b 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -7142,6 +7142,14 @@ expected=${dst_mac}${src_mac}08004500001c000000003f110100${src_ip}${dst_ip}00351
>  echo $expected >> hv2-vif1.expected
>  OVN_CHECK_PACKETS([hv2/vif1-tx.pcap], [hv2-vif1.expected])
>
> +AT_CHECK([ovn-sbctl --bare --columns _uuid find Port_Binding logical_port=cr-alice | wc --lines], [0], [1
> +])
> +
> +ovn-nbctl remove Logical_Router_Port alice options redirect-chassis

I think we should  add "--sync=sb" here to ensure ovn-northd processes
our change before doing the next check.

I've added it.

> +
> +AT_CHECK([ovn-sbctl find Port_Binding logical_port=cr-alice | wc --lines], [0], [0
> +])
> +
>  OVN_CLEANUP([hv1],[hv2],[hv3])
>
>  AT_CLEANUP

I tweaked the subject line to remove "l3ha" since this patch isn't
really l3ha code.

I made the above changes and applied this to master.
diff mbox

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index efcbd91..f3e6b4b 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -7142,6 +7142,14 @@  expected=${dst_mac}${src_mac}08004500001c000000003f110100${src_ip}${dst_ip}00351
 echo $expected >> hv2-vif1.expected
 OVN_CHECK_PACKETS([hv2/vif1-tx.pcap], [hv2-vif1.expected])
 
+AT_CHECK([ovn-sbctl --bare --columns _uuid find Port_Binding logical_port=cr-alice | wc --lines], [0], [1
+])
+
+ovn-nbctl remove Logical_Router_Port alice options redirect-chassis
+
+AT_CHECK([ovn-sbctl find Port_Binding logical_port=cr-alice | wc --lines], [0], [0
+])
+
 OVN_CLEANUP([hv1],[hv2],[hv3])
 
 AT_CLEANUP