diff mbox

[ovs-dev,1/2] checkpatch: Suggest ovs_assert() to author.

Message ID 1497818890-96089-1-git-send-email-bhanuprakash.bodireddy@intel.com
State Accepted
Headers show

Commit Message

Bodireddy, Bhanuprakash June 18, 2017, 8:48 p.m. UTC
Suggest the author to use the OVS wrapper of the assert function.

Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
---
 utilities/checkpatch.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Aaron Conole June 26, 2017, 7:13 p.m. UTC | #1
Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> writes:

> Suggest the author to use the OVS wrapper of the assert function.
>
> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
> ---

LGTM,  Thanks Bhanu.

Acked-by: Aaron Conole <aconole@redhat.com>
Ben Pfaff July 12, 2017, 4:29 p.m. UTC | #2
On Mon, Jun 26, 2017 at 03:13:05PM -0400, Aaron Conole wrote:
> Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> writes:
> 
> > Suggest the author to use the OVS wrapper of the assert function.
> >
> > Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
> > ---
> 
> LGTM,  Thanks Bhanu.
> 
> Acked-by: Aaron Conole <aconole@redhat.com>

Thanks, applied to master.
diff mbox

Patch

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index b45a255..304d2fd 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -256,6 +256,7 @@  std_functions = [
         ('strerror', 'Use ovs_strerror() in place of strerror()'),
         ('sleep', 'Use xsleep() in place of sleep()'),
         ('abort', 'Use ovs_abort() in place of abort()'),
+        ('assert', 'Use ovs_assert() in place of assert()'),
         ('error', 'Use ovs_error() in place of error()'),
 ]
 checks += [