| Message ID | 1497286187-69287-5-git-send-email-bhanuprakash.bodireddy@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Bhanu, Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> writes: > With this commit the keepalive framework is invoked when enable-keepalive > is set to 'true' in ovsdb. As part of initialization the shared memory block > is created and initialized. Also the keepalive data structure is initialized > and the callback functions are registered if DPDK datapath is enabled. > > Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> > --- This needs to be folded in with 03/19, so please squash these commits in the next version. There is no need to keep them separate. In fact, the commit message from the previous implies that the feature will at least be usable. However, without this commit that is not the case. -Aaron
>Hi Bhanu, > >Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> writes: > >> With this commit the keepalive framework is invoked when >> enable-keepalive is set to 'true' in ovsdb. As part of initialization >> the shared memory block is created and initialized. Also the keepalive >> data structure is initialized and the callback functions are registered if DPDK >datapath is enabled. >> >> Signed-off-by: Bhanuprakash Bodireddy >> <bhanuprakash.bodireddy@intel.com> >> --- > >This needs to be folded in with 03/19, so please squash these commits in the >next version. > >There is no need to keep them separate. In fact, the commit message from >the previous implies that the feature will at least be usable. >However, without this commit that is not the case. Sure Aaron, I will fold this changes in to the other commit. Bhanuprakash.
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index cc7a43b..d40879d 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -34,6 +34,7 @@ #include "hmapx.h" #include "if-notifier.h" #include "jsonrpc.h" +#include "keepalive.h" #include "lacp.h" #include "mac-learning.h" #include "mcast-snooping.h" @@ -2958,6 +2959,9 @@ bridge_run(void) dpdk_init(&cfg->other_config); } + /* Initialize Keepalive framework */ + ka_init(&cfg->other_config); + /* Initialize the ofproto library. This only needs to run once, but * it must be done after the configuration is set. If the * initialization has already occurred, bridge_init_ofproto()
With this commit the keepalive framework is invoked when enable-keepalive is set to 'true' in ovsdb. As part of initialization the shared memory block is created and initialized. Also the keepalive data structure is initialized and the callback functions are registered if DPDK datapath is enabled. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> --- vswitchd/bridge.c | 4 ++++ 1 file changed, 4 insertions(+)