diff mbox

[ovs-dev] doc: Add more details for in_port.

Message ID 1497073616-62748-1-git-send-email-nic@opencloud.tech
State Superseded
Headers show

Commit Message

nickcooper-zhangtonghao June 10, 2017, 5:46 a.m. UTC
When I test OvS openflow, I confuse the 'in_port' with
'output:in_port'. I doc the openflow.rst and it may
help others to avoid it.

Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>
---
 Documentation/faq/openflow.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ben Pfaff June 12, 2017, 3:41 p.m. UTC | #1
On Fri, Jun 09, 2017 at 10:46:56PM -0700, nickcooper-zhangtonghao wrote:
> When I test OvS openflow, I confuse the 'in_port' with
> 'output:in_port'. I doc the openflow.rst and it may
> help others to avoid it.
> 
> Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>
> ---
>  Documentation/faq/openflow.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/faq/openflow.rst b/Documentation/faq/openflow.rst
> index 7cd6161..1563893 100644
> --- a/Documentation/faq/openflow.rst
> +++ b/Documentation/faq/openflow.rst
> @@ -362,6 +362,10 @@ but OVS drops the packets instead.
>  
>          $ ovs-ofctl add-flow br0 in_port=2,actions=in_port
>  
> +    But if you use the ``output:in_port``, the packet is not output.::
> +
> +        $ ovs-ofctl add-flow br0 in_port=2,actions=output:in_port
> +

Thanks for the patch.  This was in fact a bug.  I sent out a fix:
        https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/333858.html
diff mbox

Patch

diff --git a/Documentation/faq/openflow.rst b/Documentation/faq/openflow.rst
index 7cd6161..1563893 100644
--- a/Documentation/faq/openflow.rst
+++ b/Documentation/faq/openflow.rst
@@ -362,6 +362,10 @@  but OVS drops the packets instead.
 
         $ ovs-ofctl add-flow br0 in_port=2,actions=in_port
 
+    But if you use the ``output:in_port``, the packet is not output.::
+
+        $ ovs-ofctl add-flow br0 in_port=2,actions=output:in_port
+
     This also works in some circumstances where the flow doesn't match on the
     input port.  For example, if you know that your switch has five ports
     numbered 2 through 6, then the following will send every received packet