| Message ID | 1497009108-9052-3-git-send-email-ktraynor@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
On 6/9/17, 4:51 AM, "Kevin Traynor" <ktraynor@redhat.com> wrote:
Rx checksum offload is enabled by default on DPDK NICs where
supported. Previously Rx checksum offload not supported was
logged on first configure only. The DPDK port may be configured
multiple times so log on each configure.
I was thinking about allowing reporting for multiple devices, not the same device
multiple times. Can you update the commit message ?
Suggested-by: Darrell Ball <dlu998@gmail.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
lib/netdev-dpdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 5c05e79..ecfddb8 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -744,5 +744,5 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
if ((info.rx_offload_capa & rx_chksm_offload_capa) !=
rx_chksm_offload_capa) {
- VLOG_WARN_ONCE("Rx checksum offload is not supported on device %"PRIu8,
+ VLOG_WARN("Rx checksum offload is not supported on port %"PRIu8,
dev->port_id);
dev->hw_ol_features &= ~NETDEV_RX_CHECKSUM_OFFLOAD;
--
1.8.3.1
On 06/09/2017 05:06 PM, Darrell Ball wrote: > > > On 6/9/17, 4:51 AM, "Kevin Traynor" <ktraynor@redhat.com> wrote: > > Rx checksum offload is enabled by default on DPDK NICs where > supported. Previously Rx checksum offload not supported was > logged on first configure only. The DPDK port may be configured > multiple times so log on each configure. > > I was thinking about allowing reporting for multiple devices, not the same device > multiple times. Can you update the commit message ? > Ah, right, good catch thanks. I guess I made the right fix for the wrong reason :-) v5 with updated commit message on the way > > Suggested-by: Darrell Ball <dlu998@gmail.com> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com> > --- > lib/netdev-dpdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 5c05e79..ecfddb8 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -744,5 +744,5 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) > if ((info.rx_offload_capa & rx_chksm_offload_capa) != > rx_chksm_offload_capa) { > - VLOG_WARN_ONCE("Rx checksum offload is not supported on device %"PRIu8, > + VLOG_WARN("Rx checksum offload is not supported on port %"PRIu8, > dev->port_id); > dev->hw_ol_features &= ~NETDEV_RX_CHECKSUM_OFFLOAD; > -- > 1.8.3.1 > > >
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 5c05e79..ecfddb8 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -744,5 +744,5 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) if ((info.rx_offload_capa & rx_chksm_offload_capa) != rx_chksm_offload_capa) { - VLOG_WARN_ONCE("Rx checksum offload is not supported on device %"PRIu8, + VLOG_WARN("Rx checksum offload is not supported on port %"PRIu8, dev->port_id); dev->hw_ol_features &= ~NETDEV_RX_CHECKSUM_OFFLOAD;
Rx checksum offload is enabled by default on DPDK NICs where supported. Previously Rx checksum offload not supported was logged on first configure only. The DPDK port may be configured multiple times so log on each configure. Suggested-by: Darrell Ball <dlu998@gmail.com> Signed-off-by: Kevin Traynor <ktraynor@redhat.com> --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)