From patchwork Tue Dec 6 06:45:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 703040 X-Patchwork-Delegate: blp@nicira.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tXsZh07hgz9sdn for ; Tue, 6 Dec 2016 17:45:31 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id F2FECB43; Tue, 6 Dec 2016 06:45:26 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0CB1DB3F for ; Tue, 6 Dec 2016 06:45:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3B5A715A for ; Tue, 6 Dec 2016 06:45:25 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OHR0051443MMD70@mailout2.w1.samsung.com> for dev@openvswitch.org; Tue, 06 Dec 2016 06:45:22 +0000 (GMT) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161206064521eucas1p2bd2aa52817ca51557a2f7ef2475dbb9f~Nl8QzlBpX2492224922eucas1p26; Tue, 6 Dec 2016 06:45:21 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges5.samsung.com (EUCPMTA) with SMTP id BE.81.19540.18E56485; Tue, 6 Dec 2016 06:45:21 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161206064520eucas1p2564c02bbd91d4f2d4f15f49cec634bd3~Nl8P_z6Ju2376223762eucas1p2N; Tue, 6 Dec 2016 06:45:20 +0000 (GMT) X-AuditID: cbfec7f5-f79ce6d000004c54-82-58465e811131 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8E.29.10494.C6E56485; Tue, 6 Dec 2016 06:45:00 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OHR00IJ743FMW00@eusync3.samsung.com>; Tue, 06 Dec 2016 06:45:20 +0000 (GMT) From: Ilya Maximets To: dev@openvswitch.org, Daniele Di Proietto Date: Tue, 06 Dec 2016 09:45:07 +0300 Message-id: <1481006707-8843-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsWy7djPc7qNcW4RBo+Xc1q8mtzAaNHSP5PZ 4ujpPcwWL7vvsVtM+3yb3eJK+092i8mzpRzYPRbvecnk8ezmf0aP59d6WDz6tqxi9Hg3/y1b AGsUl01Kak5mWWqRvl0CV8bWj6fYCj6yVqyY/p2xgfEWSxcjJ4eEgInE1zUTWSFsMYkL99az dTFycQgJLGWU+N2yjgnC+cwosez0A3aYjosvXzBCJJYxSvzZP5sZwmlmkvi+ag9YFZuAjsSp 1UcYQWwRAVeJ6bffsIMUMQvsZpS4uHk7G0hCWMBd4uvVx0wgNouAqsSH5udgNi9QQ/ua21BH yUncPNcJtkFC4DqbxOfNrUAOB5AjK7HpADNEjYvE/W0HoB4Slnh1fAvUqTISlyd3Q8WrJSZu bWOHmNPCKLFw4g+oBfYSp25eBVvMLMAnMWnbdKj5vBIdbUIQJR4Sx182sUHYjhJvr88Cmy8k ECtx695NtgmM0gsYGVYxiqSWFuempxab6hUn5haX5qXrJefnbmIExurpf8e/7mBceszqEKMA B6MSD+/nBtcIIdbEsuLK3EOMEhzMSiK8N2PcIoR4UxIrq1KL8uOLSnNSiw8xSnOwKInz7llw JVxIID2xJDU7NbUgtQgmy8TBKdXAuE6a6YjPyfW7NdbGd5T/DmlMdLvP7xvoYv48XfPr7EtM a0N6la4UL0qYpNNhmr40cN+NY/Oalpi9OtM3eX6hoMzR9Mtb3DeV9PNxxOhpMk2w1b756hTD aY3U6sw0MQ0BoYVrzX7KLHF4dH2nj5etW7euYUPZ6U8/78/9aHxQav97G06Xe29eKbEUZyQa ajEXFScCAC6q8orRAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xq7o5cW4RBpM+iVm8mtzAaNHSP5PZ 4ujpPcwWL7vvsVtM+3yb3eJK+092i8mzpRzYPRbvecnk8ezmf0aP59d6WDz6tqxi9Hg3/y1b AGuUm01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJOKZBnZIAGHJwD 3IOV9O0S3DK2fjzFVvCRtWLF9O+MDYy3WLoYOTkkBEwkLr58wQhhi0lcuLeerYuRi0NIYAmj xN2GQ1BOK5PE2Z1HwarYBHQkTq0+AmaLCLhKTL/9hh2kiFlgN6PEhPmLWEESwgLuEl+vPmYC sVkEVCU+ND8Hs3mBGtrX3GaFWCcncfNcJ/MERu4FjAyrGEVSS4tz03OLjfSKE3OLS/PS9ZLz czcxAsNz27GfW3Ywdr0LPsQowMGoxMP7ocE1Qog1say4MvcQowQHs5II780Ytwgh3pTEyqrU ovz4otKc1OJDjKZAyycyS4km5wNjJ68k3tDE0NzS0MjYwsLcyEhJnHfqhyvhQgLpiSWp2amp BalFMH1MHJxSDYzCN093LHi7ISP0sPpPifdesySuvA9PKI1qdi62N/Ke0NQctP7j3lMBi2/L fDN7ncXp4qPhKCZ1a35Gq//ZD4FFy+Kvfb/Ld5rRZ8a8nRt3u5Ul+7Ex/565Xi+zVza9Xv9G ZR/3tp9rrm6R3cBVJyiw8cy1zPXMfzVfmy1SMfE9v03WueptnqASS3FGoqEWc1FxIgDEpdji ZQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161206064520eucas1p2564c02bbd91d4f2d4f15f49cec634bd3 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161206064520eucas1p2564c02bbd91d4f2d4f15f49cec634bd3 X-RootMTR: 20161206064520eucas1p2564c02bbd91d4f2d4f15f49cec634bd3 References: X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Dyasly Sergey Subject: [ovs-dev] [PATCH v2] netdev-dpdk: Don't use dev->vhost_id without mutex. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The copy should be used here. Additionally, 'strlen' changed to the faster check. Fixes: 821b86649a90 ("netdev-dpdk: Don't try to unregister empty vhost_id.") Signed-off-by: Ilya Maximets --- Version 2: * 'strlen' --> '[0]' (Suggested by Ben Pfaff) lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 6e5cd43..61d7aa3 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1027,7 +1027,7 @@ netdev_dpdk_vhost_destruct(struct netdev *netdev) ovs_mutex_unlock(&dev->mutex); ovs_mutex_unlock(&dpdk_mutex); - if (!strlen(dev->vhost_id)) { + if (!vhost_id[0]) { goto out; }