| Message ID | 1479764561-16741-2-git-send-email-yihung.wei@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Daniele Di Proietto |
| Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tN2CW22R5z9sxS for <incoming@patchwork.ozlabs.org>; Tue, 22 Nov 2016 08:43:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ms5Y1i1M"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id F1EA4B7A; Mon, 21 Nov 2016 21:42:54 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id DF44DB75 for <ovs-dev@openvswitch.org>; Mon, 21 Nov 2016 21:42:53 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A285FFB for <ovs-dev@openvswitch.org>; Mon, 21 Nov 2016 21:42:53 +0000 (UTC) Received: by mail-pf0-f193.google.com with SMTP id c4so16346427pfb.3 for <ovs-dev@openvswitch.org>; Mon, 21 Nov 2016 13:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yN6rCIAffeACzq+BBb6lu50gBtOt5KpvAP+wDN93xdk=; b=Ms5Y1i1MWIqSP7clNNVEzBy9w2O5af3LeKuGzOVZlLrC9OYP+QqHLO6LNLg8hEjCup vsCtY/tGOCCtCz2H64jKqVjf+33OoJXB+QTIq0wr0axkr50EgUx0iFPrwIMioHkAKFpE CkLkzK3i033KXx5DnWqqMOss1OO/ybXKDiBJyBSKQbFLUNDqKKN32pjY6EHGWAfLLdfr JfHLUfNFIKOtqgdkOPVjGypIgDxUP5PyMj4+5THlYWCzeqkXEczT5IWbev1q/Dh/DQ+s rSv763Vikde4opR3GGjs6Ho+P8AmoL4RSwYqAm5DrDwllmdmDfAQhK4VJkUcOCEMLxPH m5hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yN6rCIAffeACzq+BBb6lu50gBtOt5KpvAP+wDN93xdk=; b=HR+e4ncGa+lT3wkHiPc49igSCE3NgiIz1+b3V6JkKoB0GVYdAitWT6zNBHpqywXG2C iNDjrYCN/JDoHbEiYMR3+jN5lKa0Z8C//IhsomQ7dIbppLT0qt2OoXpkYHVVUs9vGhtz zmplO+8vCRAtVVlIwpyvvm15zAZc8gIuXCSVvqs7xzC6ABL9lRYAfVb4zl7jOtMulywC tF+MLKuVnN08NGYbOXI+N33VchwqaqivbMbDtCmzotrc437wBu1aw1+u6lIhPTTYAD8H fGWqwzZZj0l3NWYifo/pOdn3vLf11OARluQKJTOeIilt+5Flv3ko+MmvU+j82GsGtPo3 0MJQ== X-Gm-Message-State: AKaTC03l1A8LfXtdfK6ib/qnCEO8jZH2ae2+TRDrrm6r3yYdNUgG8sz8NZHKo/iGY94EHg== X-Received: by 10.99.9.66 with SMTP id 63mr36843198pgj.84.1479764573297; Mon, 21 Nov 2016 13:42:53 -0800 (PST) Received: from sc9-mailhost3.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id w24sm39688557pfa.9.2016.11.21.13.42.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Nov 2016 13:42:52 -0800 (PST) From: Yi-Hung Wei <yihung.wei@gmail.com> To: ovs-dev@openvswitch.org Date: Mon, 21 Nov 2016 13:42:40 -0800 Message-Id: <1479764561-16741-2-git-send-email-yihung.wei@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479764561-16741-1-git-send-email-yihung.wei@gmail.com> References: <1479764561-16741-1-git-send-email-yihung.wei@gmail.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Yi-Hung Wei <yihung.wei@gmail.com> Subject: [ovs-dev] [PATCH 2/3] ofp-print: Fix memory leak in ofp_print_queue_get_config_reply(). X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
diff --git a/lib/ofp-print.c b/lib/ofp-print.c index b7b5290..7b7c430 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -1263,6 +1263,7 @@ ofp_print_queue_get_config_reply(struct ds *string, ofp_print_error(string, retval); } ds_chomp(string, ' '); + free(queues); } static void
In testcase "OFPT_QUEUE_GET_CONFIG_REPLY - OF1.0", valgrind reports a memory leak with the following call stack. xrealloc (util.c:123) ofp_print_queue_get_config_reply (ofp-print.c:1233) ofp_to_string__ (ofp-print.c:3458) ofp_to_string (ofp-print.c:3681) ofp_print (ofp-print.c:3713) ofctl_ofp_print (ovs-ofctl.c:4399) ovs_cmdl_run_command__ (command-line.c:115) main (ovs-ofctl.c:151) Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com> --- lib/ofp-print.c | 1 + 1 file changed, 1 insertion(+)