From patchwork Mon Nov 14 09:24:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: nickcooper-zhangtonghao X-Patchwork-Id: 694428 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tHQBH1rJXz9t0G for ; Mon, 14 Nov 2016 20:26:15 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A1BCABBC; Mon, 14 Nov 2016 09:24:41 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp2.linuxfoundation.org (smtp2.linux-foundation.org [172.17.192.36]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B73B8BE5 for ; Mon, 14 Nov 2016 09:24:38 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtpbg202.qq.com (smtpbg202.qq.com [184.105.206.29]) by smtp2.linuxfoundation.org (Postfix) with ESMTPS id 045AF1DB07 for ; Mon, 14 Nov 2016 09:24:37 +0000 (UTC) X-QQ-mid: bizesmtp9t1479115463t4beix1b1 Received: from localhost.localdomain.localdoma (unknown [106.120.127.11]) by esmtp4.qq.com (ESMTP) with id ; Mon, 14 Nov 2016 17:24:22 +0800 (CST) X-QQ-SSF: 01100000002000209250B00A0000000 X-QQ-FEAT: raNNwdt7yZBvivfZt1yTEeGMOp6FfmKEXCezt+zdlYPJdSdsADB5QqtRi1a1w 1uycHT7jnV0CREt7dkL8ZocE56lE9WQDKGNNbcjQvoHtJ9ix2ZWslCQoUzZyNk0u16wIen5 PGS8UlLF6O+S/tTqOn/TWtJULFKkh4thXDcXou5J3DS3UzAK83JrprEXm+BENaAIt8KlmKm RZzqduX0SEHFadmh+Ig/JM1Zt0zFnexDUYykTp/bgdWOrZmPXhBsCPgNlzatvutSpzIQZOw 4tWw== X-QQ-GoodBg: 0 From: nickcooper-zhangtonghao To: ovs-dev@openvswitch.org Date: Mon, 14 Nov 2016 01:24:11 -0800 Message-Id: <1479115454-48163-2-git-send-email-nic@opencloud.tech> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1479115454-48163-1-git-send-email-nic@opencloud.tech> References: <1479115454-48163-1-git-send-email-nic@opencloud.tech> X-QQ-SENDSIZE: 520 X-QQ-Bgrelay: 1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp2.linux-foundation.org Cc: nickcooper-zhangtonghao Subject: [ovs-dev] [PATCH v2 1/4] ovs-tcpdump: Remove the newline from readline(). X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When using ovs-tcpdump, we always get the white line. Remove newline from readline() and ovs-tcpdump will format the output as tcpdump tool. Signed-off-by: nickcooper-zhangtonghao Acked-by: Aaron Conole --- utilities/ovs-tcpdump.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index b29e691..01e1f6d 100755 --- a/utilities/ovs-tcpdump.in +++ b/utilities/ovs-tcpdump.in @@ -426,7 +426,7 @@ def main(): pipes = _doexec(*([dump_cmd, '-i', mirror_interface] + tcpdargs)) try: while pipes.poll() is None: - data = pipes.stdout.readline() + data = pipes.stdout.readline().strip('\n') if len(data) == 0: raise KeyboardInterrupt print(data)