From patchwork Fri Sep 23 13:17:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 674081 X-Patchwork-Delegate: diproiettod@vmware.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3sgYp01CMxz9snm for ; Fri, 23 Sep 2016 23:18:16 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 05063108FC; Fri, 23 Sep 2016 06:18:15 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id B2F82108F8 for ; Fri, 23 Sep 2016 06:18:13 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id 76A5F1E036B for ; Fri, 23 Sep 2016 07:18:12 -0600 (MDT) X-ASG-Debug-ID: 1474636691-09eadd7ac9b11a0001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar5.cudamail.com with ESMTP id 2EbldVofWoeZ0WTp (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 23 Sep 2016 07:18:11 -0600 (MDT) X-Barracuda-Envelope-From: i.maximets@samsung.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mailout4.w1.samsung.com) (210.118.77.14) by mx3-pf2.cudamail.com with ESMTPS (DHE-RSA-AES128-SHA encrypted); 23 Sep 2016 13:18:11 -0000 Received-SPF: none (mx3-pf2.cudamail.com: domain at samsung.com does not designate permitted sender hosts) X-Barracuda-Apparent-Source-IP: 210.118.77.14 X-Barracuda-RBL-IP: 210.118.77.14 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ODY00DYNKY74RA0@mailout4.w1.samsung.com> for dev@openvswitch.org; Fri, 23 Sep 2016 14:18:07 +0100 (BST) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20160923131807eucas1p19eb331fe4a205daa5fd40839d540eeaf~29kEIgQ1u1555015550eucas1p16; Fri, 23 Sep 2016 13:18:07 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 30.FD.02283.E8B25E75; Fri, 23 Sep 2016 14:18:06 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20160923131806eucas1p20a39d6ed7f50c8a68cce7c60ad15a2ff~29kDj2Rev2343623436eucas1p2j; Fri, 23 Sep 2016 13:18:06 +0000 (GMT) X-AuditID: cbfec7f1-f79f46d0000008eb-e1-57e52b8e2ad1 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id A0.4F.07726.86B25E75; Fri, 23 Sep 2016 14:17:28 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ODY00C75KY1SS90@eusync1.samsung.com>; Fri, 23 Sep 2016 14:18:06 +0100 (BST) X-CudaMail-Envelope-Sender: i.maximets@samsung.com From: Ilya Maximets To: dev@openvswitch.org, Daniele Di Proietto X-CudaMail-MID: CM-V2-922010163 X-CudaMail-DTE: 092316 X-CudaMail-Originating-IP: 210.118.77.14 Date: Fri, 23 Sep 2016 16:17:56 +0300 X-ASG-Orig-Subj: [##CM-V2-922010163##][PATCH] netdev-dpdk: Add missed lock in set_config for vhost client mode. Message-id: <1474636678-20649-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWy7djP87p92k/DDTbct7Bo6Z/JbHH09B5m i5fd99gtpn2+zW5xpf0nu8Xk2VIObB6L97xk8nh28z+jR9+WVYwe7+a/ZQtgieKySUnNySxL LdK3S+DK6D1+mLWggaNi8vN25gbGjWxdjBwcEgImEh3TbbsYOYFMMYkL99YDhbk4hASWMkos 7D/EBOF8ZpR49/UzO0SVicSiHbPYIRLLGCU2N8yDcpqZJO5972MBqWIT0JE4tfoII4gtIuAq Mf32G7AiZoFFjBJXDj5lBkkIC4RIdF39wgpiswioSjx9tw3M5hVwk3jxpJ0ZYp2cxM1znVD2 CTaJFb8jIO6Wldh0ACrsIvFk92cWCFtY4tXxLVCXykh0dhxkgrCrJSZubQO7QUKgBei3iT9Y IRL2EqduXgUrYhbgk5i0bTozxHxeiY42IYgSD4nzk04zQYQdJU690QAJCwnESvTNnsQygVF6 ASPDKkaR1NLi3PTUYiO94sTc4tK8dL3k/NxNjMCIPP3v+McdjO9PWB1iFOBgVOLhffD4cbgQ a2JZcWXuIUYJDmYlEV51jafhQrwpiZVVqUX58UWlOanFhxilOViUxHn3LLgSLiSQnliSmp2a WpBaBJNl4uCUamDM/rC54+XKKf+5t3oyRlZJ1a4znvGhx/b+hBu3oo6v3LDf19iI+1iUU8eh RfZJTvNFQ1VOaMre0uZg9OX/GlpwscC18/4fi8k1s/Yks0lk1G68uPWg8pyVQetKQl1ebdkS klLz1mlxqd67vZ+iv91lOG1yKEKbc8MkacNPXG5xvIXiX5w/CXQosRRnJBpqMRcVJwIA2S9N 0sQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t/xy7oZ2k/DDR79ErJo6Z/JbHH09B5m i5fd99gtpn2+zW5xpf0nu8Xk2VIObB6L97xk8nh28z+jR9+WVYwe7+a/ZQtgiXKzyUhNTEkt UkjNS85PycxLt1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbRu/x w6wFDRwVk5+3MzcwbmTrYuTkkBAwkVi0YxY7hC0mceHeerC4kMASRolny8y7GLmA7FYmia0n poIl2AR0JE6tPsIIYosIuEpMv/2GHaSIWWARo8Ta35/BioQFQiS6rn5hBbFZBFQlnr7bBmbz CrhJvHjSzgyxTU7i5rlO5gmM3AsYGVYxiqSWFuem5xYb6hUn5haX5qXrJefnbmIEBuK2Yz83 72C8tDH4EKMAB6MSD2/Hw8fhQqyJZcWVuYcYJTiYlUR41TWehgvxpiRWVqUW5ccXleakFh9i NAVaPpFZSjQ5HxgleSXxhiaG5paGRsYWFuZGRkrivCUfroQLCaQnlqRmp6YWpBbB9DFxcEo1 MIZ9OXljwv2I6Sl+P2eyz/LIU0l56P8kTWGK9nODKW/uBr35olBbxF4pmeOYMSNn1fXYGuMN idfeznXdekVh8s0flySSH71fuULixGbTtizPeKeV/IZCXtc+Ho/Rjg0+/y/auH5nrdij+3O+ Vj9X2d3iaFfz9VY8c8ra/RrznqvoLfxwesPOxSpKLMUZiYZazEXFiQD85AL7WgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160923131806eucas1p20a39d6ed7f50c8a68cce7c60ad15a2ff X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160923131806eucas1p20a39d6ed7f50c8a68cce7c60ad15a2ff X-RootMTR: 20160923131806eucas1p20a39d6ed7f50c8a68cce7c60ad15a2ff References: X-GBUdb-Analysis: 0, 210.118.77.14, Ugly c=0 p=0 Source New X-MessageSniffer-Rules: 0-0-0-6917-c X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1474636691 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-ASG-Whitelist: EmailCat (corporate) Cc: Ilya Maximets , Dyasly Sergey Subject: [ovs-dev] [PATCH] netdev-dpdk: Add missed lock in set_config for vhost client mode. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" 'vhost_driver_flags' and 'vhost_id' are mutable and must be protected by 'dev->mutex'. Fixes: 2d24d165d6a5 ("netdev-dpdk: Add new 'dpdkvhostuserclient' port type") Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 89bdc4d..ec43a08 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1116,6 +1116,7 @@ netdev_dpdk_vhost_client_set_config(struct netdev *netdev, struct netdev_dpdk *dev = netdev_dpdk_cast(netdev); const char *path; + ovs_mutex_lock(&dev->mutex); if (!(dev->vhost_driver_flags & RTE_VHOST_USER_CLIENT)) { path = smap_get(args, "vhost-server-path"); if (path && strcmp(path, dev->vhost_id)) { @@ -1123,6 +1124,7 @@ netdev_dpdk_vhost_client_set_config(struct netdev *netdev, netdev_request_reconfigure(netdev); } } + ovs_mutex_unlock(&dev->mutex); return 0; }