| Message ID | 1472625307-8306-1-git-send-email-abiswas@us.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Aug 31, 2016 at 12:05 PM, Amitabha Biswas <azbiswas@gmail.com> wrote: > --- > debian/ovs-monitor-ipsec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec > index e6617b0..6bc26aa 100755 > --- a/debian/ovs-monitor-ipsec > +++ b/debian/ovs-monitor-ipsec > @@ -333,7 +333,7 @@ class IPsec(object): > self.call_ip_xfrm(["policy", "add", "src", "0.0.0.0/0", "dst", > "0.0.0.0/0", "proto", "gre", "dir", "out", > "mark", IPSEC_MARK, "mask", IPSEC_MARK, > - "action", "block", "priority", "4294967295"]); > + "action", "block", "priority", "4294967295"]) > > Thanks for the patch. This fixes the compilation error which I am seeing. May be you can update the below in the commit message Fixes: 19cd0a87 Acked-by: Numan Siddique <nusiddiq@redhat.com> > def spd_add(self, local_ip, remote_ip): > cmds = ("spdadd %s %s gre -P out ipsec esp/transport//require;\n" > % > -- > 2.7.4 (Apple Git-66) > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
Amitabha Biswas <azbiswas@gmail.com> wrote on 08/31/2016 01:35:07 AM: > From: Amitabha Biswas <azbiswas@gmail.com> > To: dev@openvswitch.org > Cc: russell@ovn.org, Richard Theis/Rochester/IBM@IBMUS, Amitabha > Biswas/San Jose/IBM@IBMUS > Date: 08/31/2016 01:35 AM > Subject: [PATCH] ovs-monitor-ipsec: Fix flake8-check semicolon error > > --- > debian/ovs-monitor-ipsec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec > index e6617b0..6bc26aa 100755 > --- a/debian/ovs-monitor-ipsec > +++ b/debian/ovs-monitor-ipsec > @@ -333,7 +333,7 @@ class IPsec(object): > self.call_ip_xfrm(["policy", "add", "src", "0.0.0.0/0", "dst", > "0.0.0.0/0", "proto", "gre", "dir", "out", > "mark", IPSEC_MARK, "mask", IPSEC_MARK, > - "action", "block", "priority", "4294967295"]); > + "action", "block", "priority", "4294967295"]) > > def spd_add(self, local_ip, remote_ip): > cmds = ("spdadd %s %s gre -P out ipsec esp/transport//require;\n" % > -- > 2.7.4 (Apple Git-66) > The OpenStack networking-ovn gate should be fixed with this change. This change was tested as part of OpenStack patch set https://review.openstack.org/#/c/363305/. - Richard
diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec index e6617b0..6bc26aa 100755 --- a/debian/ovs-monitor-ipsec +++ b/debian/ovs-monitor-ipsec @@ -333,7 +333,7 @@ class IPsec(object): self.call_ip_xfrm(["policy", "add", "src", "0.0.0.0/0", "dst", "0.0.0.0/0", "proto", "gre", "dir", "out", "mark", IPSEC_MARK, "mask", IPSEC_MARK, - "action", "block", "priority", "4294967295"]); + "action", "block", "priority", "4294967295"]) def spd_add(self, local_ip, remote_ip): cmds = ("spdadd %s %s gre -P out ipsec esp/transport//require;\n" %