| Message ID | 1472502515-28450-1-git-send-email-lrichard@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
Lance, We discussed this off-line last week and the proper fix would be to change the log level for that message to to debug. Could you post a patch to do that? Jarno > On Aug 29, 2016, at 1:28 PM, Lance Richardson <lrichard@redhat.com> wrote: > > The conntrack - controller test case currently fails for the kernel data > path due to occurrences of the log message "upcall: no reference for recirc > flow". This began with commit b4c632526b68 ("upcall: Log failure to flow_put > for dpif-netlink."), which introduced this message for the kernel data path. > > This log message means that an upcall with a recirc reference was received > when the associated recirc id was expired/expiring. > > Eliminate the failure cause by ignoring the "no reference for recirc flow" > message when checking vswitchd log. > > Signed-off-by: Lance Richardson <lrichard@redhat.com> > --- > tests/system-traffic.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index 10b2647..3badb98 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -526,7 +526,7 @@ NXT_PACKET_IN2 (xid=0x0): cookie=0x0 total_len=42 ct_state=est|rpl|trk,in_port=2 > udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.2,nw_dst=10.1.1.1,nw_tos=0,nw_ecn=0,nw_ttl=0,tp_src=2,tp_dst=1 udp_csum:0 > ]) > > -OVS_TRAFFIC_VSWITCHD_STOP > +OVS_TRAFFIC_VSWITCHD_STOP(["/upcall: no reference for recirc flow/d"]) > AT_CLEANUP > > AT_SETUP([conntrack - IPv4 HTTP]) > -- > 2.5.5 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
> From: "Jarno Rajahalme" <jarno@ovn.org> > To: "Lance Richardson" <lrichard@redhat.com> > Cc: dev@openvswitch.org > Sent: Monday, August 29, 2016 4:41:28 PM > Subject: Re: [ovs-dev] [PATCH] system-traffic: Ignore "no reference for recirc flow" in ct controller test > > Lance, > > We discussed this off-line last week and the proper fix would be to change > the log level for that message to to debug. Could you post a patch to do > that? > > Jarno > Hi Jarno, Sure, I'll spin a v2 to use VLOG_DBG() instead of VLOG_WARN(). Thanks, Lance
diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 10b2647..3badb98 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -526,7 +526,7 @@ NXT_PACKET_IN2 (xid=0x0): cookie=0x0 total_len=42 ct_state=est|rpl|trk,in_port=2 udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.2,nw_dst=10.1.1.1,nw_tos=0,nw_ecn=0,nw_ttl=0,tp_src=2,tp_dst=1 udp_csum:0 ]) -OVS_TRAFFIC_VSWITCHD_STOP +OVS_TRAFFIC_VSWITCHD_STOP(["/upcall: no reference for recirc flow/d"]) AT_CLEANUP AT_SETUP([conntrack - IPv4 HTTP])
The conntrack - controller test case currently fails for the kernel data path due to occurrences of the log message "upcall: no reference for recirc flow". This began with commit b4c632526b68 ("upcall: Log failure to flow_put for dpif-netlink."), which introduced this message for the kernel data path. This log message means that an upcall with a recirc reference was received when the associated recirc id was expired/expiring. Eliminate the failure cause by ignoring the "no reference for recirc flow" message when checking vswitchd log. Signed-off-by: Lance Richardson <lrichard@redhat.com> --- tests/system-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)