| Message ID | 1472222398-5780-10-git-send-email-pboca@cloudbasesolutions.com |
|---|---|
| State | Superseded |
| Delegated to: | Guru Shetty |
| Headers | show |
On 26 August 2016 at 07:40, Paul Boca <pboca@cloudbasesolutions.com> wrote: > The tests are not intended to run on Windows. > Can you explain why? What part of the test gives a problem in Windows? Is it that the ovs-vtep.py has not been ported to Windows? > Until now they were skipped based on $HAVE_PYTHON only. > > Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> > --- > tests/ovn-controller-vtep.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at > index 654c212..3f024cb 100644 > --- a/tests/ovn-controller-vtep.at > +++ b/tests/ovn-controller-vtep.at > @@ -15,7 +15,7 @@ m4_define([OVN_CONTROLLER_VTEP_START], > [ > AT_KEYWORDS([ovn]) > # this will cause skip when 'make check' using Windows setup. > - AT_SKIP_IF([test $HAVE_PYTHON = no]) > + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) > > dnl Create databases (ovn-nb, ovn-sb, vtep). > AT_CHECK([ovsdb-tool create vswitchd.db $abs_top_srcdir/vswitchd/ > vswitch.ovsschema]) > -- > 2.7.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index 654c212..3f024cb 100644 --- a/tests/ovn-controller-vtep.at +++ b/tests/ovn-controller-vtep.at @@ -15,7 +15,7 @@ m4_define([OVN_CONTROLLER_VTEP_START], [ AT_KEYWORDS([ovn]) # this will cause skip when 'make check' using Windows setup. - AT_SKIP_IF([test $HAVE_PYTHON = no]) + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) dnl Create databases (ovn-nb, ovn-sb, vtep). AT_CHECK([ovsdb-tool create vswitchd.db $abs_top_srcdir/vswitchd/vswitch.ovsschema])
The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> --- tests/ovn-controller-vtep.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)