diff mbox

[ovs-dev] ovn: make external_ids naming uniform

Message ID 1470946980-8311-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it
State Accepted
Headers show

Commit Message

Mauricio Vásquez Aug. 11, 2016, 8:23 p.m. UTC
In some places it is called "external-ids" while in others "external_ids"
is used. This commit changes it to external_ids in all of them.

Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>
---
 ovn/controller/ovn-controller.8.xml | 12 ++++++------
 ovn/ovn-architecture.7.xml          |  8 ++++----
 2 files changed, 10 insertions(+), 10 deletions(-)

Comments

Russell Bryant Aug. 11, 2016, 8:39 p.m. UTC | #1
On Thu, Aug 11, 2016 at 4:23 PM, Mauricio Vasquez B <
mauricio.vasquezbernal@studenti.polito.it> wrote:

> In some places it is called "external-ids" while in others "external_ids"
> is used. This commit changes it to external_ids in all of them.
>
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@
> studenti.polito.it>
> ---
>  ovn/controller/ovn-controller.8.xml | 12 ++++++------
>  ovn/ovn-architecture.7.xml          |  8 ++++----
>  2 files changed, 10 insertions(+), 10 deletions(-)
>

Thanks!  I applied this patch to master.
diff mbox

Patch

diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml
index 3fda8e7..4681b3f 100644
--- a/ovn/controller/ovn-controller.8.xml
+++ b/ovn/controller/ovn-controller.8.xml
@@ -159,7 +159,7 @@ 
     <h1>Open vSwitch Database Usage</h1>
 
     <p>
-      <code>ovn-controller</code> uses a number of <code>external-ids</code>
+      <code>ovn-controller</code> uses a number of <code>external_ids</code>
       keys in the Open vSwitch database to keep track of ports and interfaces.
       For proper operation, users should not change or clear these keys:
     </p>
@@ -176,7 +176,7 @@ 
       </dd>
 
       <dt>
-        <code>external-ids:ovn-localnet-port</code> in the <code>Port</code>
+        <code>external_ids:ovn-localnet-port</code> in the <code>Port</code>
         table
       </dt>
       <dd>
@@ -193,13 +193,13 @@ 
         <p>
           Each <code>localnet</code> logical port is implemented as a pair of
           patch ports, one in the integration bridge, one in a different
-          bridge, with the same <code>external-ids:ovn-localnet-port</code>
+          bridge, with the same <code>external_ids:ovn-localnet-port</code>
           value.
         </p>
       </dd>
 
       <dt>
-        <code>external-ids:ovn-l2gateway-port</code> in the <code>Port</code>
+        <code>external_ids:ovn-l2gateway-port</code> in the <code>Port</code>
         table
       </dt>
       <dd>
@@ -216,13 +216,13 @@ 
         <p>
           Each <code>l2gateway</code> logical port is implemented as a pair
           of patch ports, one in the integration bridge, one in a different
-          bridge, with the same <code>external-ids:ovn-l2gateway-port</code>
+          bridge, with the same <code>external_ids:ovn-l2gateway-port</code>
           value.
         </p>
       </dd>
 
       <dt>
-        <code>external-ids:ovn-logical-patch-port</code> in the
+        <code>external_ids:ovn-logical-patch-port</code> in the
         <code>Port</code> table
       </dt>
 
diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml
index 9c7166f..1a1bd39 100644
--- a/ovn/ovn-architecture.7.xml
+++ b/ovn/ovn-architecture.7.xml
@@ -447,7 +447,7 @@ 
       where the VM is powered on, the integration between the hypervisor and
       Open vSwitch (described in <code>IntegrationGuide.md</code>) adds the VIF
       to the OVN integration bridge and stores <var>vif-id</var> in
-      <code>external-ids</code>:<code>iface-id</code> to indicate that the
+      <code>external_ids</code>:<code>iface-id</code> to indicate that the
       interface is an instantiation of the new VIF.  (None of this code is new
       in OVN; this is pre-existing integration work that has already been done
       on hypervisors that support OVS.)
@@ -455,10 +455,10 @@ 
 
     <li>
       On the hypervisor where the VM is powered on, <code>ovn-controller</code>
-      notices <code>external-ids</code>:<code>iface-id</code> in the new
+      notices <code>external_ids</code>:<code>iface-id</code> in the new
       Interface. In response, in the OVN Southbound DB, it updates the
       <code>Binding</code> table's <code>chassis</code> column for the
-      row that links the logical port from <code>external-ids</code>:<code>
+      row that links the logical port from <code>external_ids</code>:<code>
       iface-id</code> to the hypervisor. Afterward, <code>ovn-controller</code>
       updates the local hypervisor's OpenFlow tables so that packets to and from
       the VIF are properly handled.
@@ -632,7 +632,7 @@ 
       <code>parent_port</code> column of <code>Binding</code> table, the
       <code>ovn-controller</code> in the hypervisor whose OVN integration bridge
       has that same value in <var>vif-id</var> in
-      <code>external-ids</code>:<code>iface-id</code>
+      <code>external_ids</code>:<code>iface-id</code>
       updates the local hypervisor's OpenFlow tables so that packets to and
       from the VIF with the particular VLAN <code>tag</code> are properly
       handled.  Afterward it updates the <code>chassis</code> column of