diff mbox

[ovs-dev,v3,1/9] meta-flow: Add ovs_be128 member to union mf_subvalue.

Message ID 1470680512-3182-2-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Aug. 8, 2016, 6:21 p.m. UTC
This makes it more convenient to access a 128-bit value stored in an
mf_subvalue.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 include/openvswitch/meta-flow.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Justin Pettit Aug. 12, 2016, 11:30 p.m. UTC | #1
> On Aug 8, 2016, at 11:21 AM, Ben Pfaff <blp@ovn.org> wrote:
> 
> This makes it more convenient to access a 128-bit value stored in an
> mf_subvalue.
> 
> Signed-off-by: Ben Pfaff <blp@ovn.org>

Acked-by: Justin Pettit <jpettit@ovn.org>

--Justin
Ben Pfaff Aug. 13, 2016, 4:29 p.m. UTC | #2
On Fri, Aug 12, 2016 at 04:30:01PM -0700, Justin Pettit wrote:
> 
> > On Aug 8, 2016, at 11:21 AM, Ben Pfaff <blp@ovn.org> wrote:
> > 
> > This makes it more convenient to access a 128-bit value stored in an
> > mf_subvalue.
> > 
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> Acked-by: Justin Pettit <jpettit@ovn.org>

Thanks, I applied this to master.

This needed a rebase due to minor changes upstream, so I'll send a v4 in
a minute.
Justin Pettit Aug. 13, 2016, 5:20 p.m. UTC | #3
> On Aug 13, 2016, at 9:29 AM, Ben Pfaff <blp@ovn.org> wrote:
> 
>> On Fri, Aug 12, 2016 at 04:30:01PM -0700, Justin Pettit wrote:
>> 
>>> On Aug 8, 2016, at 11:21 AM, Ben Pfaff <blp@ovn.org> wrote:
>>> 
>>> This makes it more convenient to access a 128-bit value stored in an
>>> mf_subvalue.
>>> 
>>> Signed-off-by: Ben Pfaff <blp@ovn.org>
>> 
>> Acked-by: Justin Pettit <jpettit@ovn.org>
> 
> Thanks, I applied this to master.
> 
> This needed a rebase due to minor changes upstream, so I'll send a v4 in
> a minute.

Thanks. I'll get back to the review this afternoon. 

--Justin
diff mbox

Patch

diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h
index aaf7da1..76d915c 100644
--- a/include/openvswitch/meta-flow.h
+++ b/include/openvswitch/meta-flow.h
@@ -1988,6 +1988,7 @@  union mf_subvalue {
     ovs_be16 be16[64];
     ovs_be32 be32[32];
     ovs_be64 be64[16];
+    ovs_be128 be128[8];
 
     /* Convenient access to just least-significant bits in various forms. */
     struct {