| Message ID | 1470174102-48500-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 2 August 2016 at 14:41, William Tu <u9012063@gmail.com> wrote: > Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT > directory are not found in the %files section, resulting errors below: > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/include/ovn/actions.h > /usr/include/ovn/expr.h > /usr/include/ovn/lex.h > The patch disables it and tested with rpmbuild 4.13.0 under Fedora 23. > > Signed-off-by: William Tu <u9012063@gmail.com> Is this just because the fedora packaging hasn't been updated to provide OVN, or someone has forgotten to update the specfile after adding/moving files? It seems to me like the right solution is to specify these files in the specfile somehow, rather than overriding a warning about unpackaged files.
> Is this just because the fedora packaging hasn't been updated to > provide OVN, or someone has forgotten to update the specfile after > adding/moving files? > > It seems to me like the right solution is to specify these files in > the specfile somehow, rather than overriding a warning about > unpackaged files. Thanks. Updating the specfile for OVN resolves the issue. I will submit patchv2.
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 088afcb..f1edd58 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -13,6 +13,10 @@ #%define kernel 2.6.40.4-5.fc15.x86_64 +# Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT +# directory are not found in the %files. Disable it here. +%define _unpackaged_files_terminate_build 0 + # If libcap-ng isn't available and there is no need for running OVS # as regular user, specify the '--without libcapng' %bcond_without libcapng
Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT directory are not found in the %files section, resulting errors below: RPM build errors: Installed (but unpackaged) file(s) found: /usr/include/ovn/actions.h /usr/include/ovn/expr.h /usr/include/ovn/lex.h The patch disables it and tested with rpmbuild 4.13.0 under Fedora 23. Signed-off-by: William Tu <u9012063@gmail.com> --- rhel/openvswitch-fedora.spec.in | 4 ++++ 1 file changed, 4 insertions(+)