From patchwork Fri Jul 29 19:18:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Russell Bryant X-Patchwork-Id: 654190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3s1JS81CLFz9t1W for ; Sat, 30 Jul 2016 05:19:03 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 63AF611597; Fri, 29 Jul 2016 12:19:02 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id ED2F71158F for ; Fri, 29 Jul 2016 12:19:00 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 12A4616129B for ; Fri, 29 Jul 2016 13:19:00 -0600 (MDT) X-ASG-Debug-ID: 1469819938-0b32374d3024ac0001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar6.cudamail.com with ESMTP id rT6bvNQTHROVFd8G (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 29 Jul 2016 13:18:58 -0600 (MDT) X-Barracuda-Envelope-From: russell@ovn.org X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO mx1.redhat.com) (209.132.183.28) by mx3-pf3.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 29 Jul 2016 19:18:58 -0000 Received-SPF: neutral (mx3-pf3.cudamail.com: 209.132.183.28 is neither permitted nor denied by SPF record at ovn.org) X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-Barracuda-RBL-IP: 209.132.183.28 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4C67D998B; Fri, 29 Jul 2016 19:18:57 +0000 (UTC) Received: from x1c.redhat.com (ovpn-112-12.phx2.redhat.com [10.3.112.12]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6TJItFe020269; Fri, 29 Jul 2016 15:18:56 -0400 X-CudaMail-Envelope-Sender: russell@ovn.org From: Russell Bryant To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V3-728035837 X-CudaMail-DTE: 072916 X-CudaMail-Originating-IP: 209.132.183.28 Date: Fri, 29 Jul 2016 15:18:35 -0400 X-ASG-Orig-Subj: [##CM-V3-728035837##][PATCH] travis: Fix flake8 failures from flake8 3.0. Message-Id: <1469819915-20496-1-git-send-email-russell@ovn.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 29 Jul 2016 19:18:57 +0000 (UTC) X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1469819938 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" The "hacking" plugin for flake8 is not currently compatible with flake8 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the docs to indicate this incompatibility. Signed-off-by: Russell Bryant --- .travis/linux-prepare.sh | 2 +- INSTALL.md | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) - Note: successfully tested in a run on travis-ci. diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh index f66146b..6570d5a 100755 --- a/.travis/linux-prepare.sh +++ b/.travis/linux-prepare.sh @@ -2,4 +2,4 @@ git clone git://git.kernel.org/pub/scm/devel/sparse/chrisl/sparse.git cd sparse && make && make install && cd .. -pip install --disable-pip-version-check --user six flake8 hacking +pip install --disable-pip-version-check --user six "flake8<3.0" hacking diff --git a/INSTALL.md b/INSTALL.md index 6fbf9ea..bb40e4a 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -127,11 +127,13 @@ installing the following to obtain better warnings: - clang, version 3.4 or later - - “flake8”, along with the “hacking” flake8 plugin (for Python code). - The automatic flake8 check that runs against Python code has some - warnings enabled that come from the "hacking" flake8 plugin. If it's - not installed, the warnings just won't occur until it's run on a system - with "hacking" installed. + - “flake8”, version 2.X, along with the “hacking” flake8 plugin (for Python + code). The automatic flake8 check that runs against Python code has some + warnings enabled that come from the "hacking" flake8 plugin. If it's not + installed, the warnings just won't occur until it's run on a system with + "hacking" installed. Note that there are problems with flake8 3.0 and the + “hacking” plugin. To ensure you get flake8 2.X, you can use + “pip install ‘flake8<3.0’”. Also, you may find the ovs-dev script found in utilities/ovs-dev.py useful.