| Message ID | 1469779641-26279-1-git-send-email-i.maximets@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Daniele Di Proietto |
| Headers | show |
Thanks for the fix, applied to master! On 29/07/2016 01:07, "Ilya Maximets" <i.maximets@samsung.com> wrote: >Revalidation should work in case of 'dynamic_txqs == true'. > >Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) implementation.") >Signed-off-by: Ilya Maximets <i.maximets@samsung.com> >--- > lib/dpif-netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >index 828171e..c446ae8 100644 >--- a/lib/dpif-netdev.c >+++ b/lib/dpif-netdev.c >@@ -4193,7 +4193,7 @@ dpif_netdev_xps_revalidate_pmd(const struct dp_netdev_pmd_thread *pmd, > long long interval; > > HMAP_FOR_EACH (tx, node, &pmd->port_cache) { >- if (tx->port->dynamic_txqs) { >+ if (!tx->port->dynamic_txqs) { > continue; > } > interval = now - tx->last_used; >-- >2.7.4 >
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 828171e..c446ae8 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4193,7 +4193,7 @@ dpif_netdev_xps_revalidate_pmd(const struct dp_netdev_pmd_thread *pmd, long long interval; HMAP_FOR_EACH (tx, node, &pmd->port_cache) { - if (tx->port->dynamic_txqs) { + if (!tx->port->dynamic_txqs) { continue; } interval = now - tx->last_used;
Revalidation should work in case of 'dynamic_txqs == true'. Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) implementation.") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)