diff mbox

[ovs-dev] doc: Update INSTALL.Docker.md to reflect it's focus on OVN

Message ID 1469641223-24341-1-git-send-email-mestery@mestery.com
State Accepted
Delegated to: Guru Shetty
Headers show

Commit Message

Kyle Mestery July 27, 2016, 5:40 p.m. UTC
While reading this document, the title stood out to me as not
accurate. The title indicates it will discuss how to use
Open vSwitch with Docker, but in reality, it's about using
Open Virtual Networking with Docker.

This change updates the title, as well as the opening paragraphs
to more accurately reflect what the document is talking about.

Signed-off-by: Kyle Mestery <mestery@mestery.com>
---
 INSTALL.Docker.md | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

Comments

Ryan Moats July 27, 2016, 5:46 p.m. UTC | #1
"dev" <dev-bounces@openvswitch.org> wrote on 07/27/2016 12:40:23 PM:

> From: Kyle Mestery <mestery@mestery.com>
> To: dev@openvswitch.org
> Date: 07/27/2016 12:40 PM
> Subject: [ovs-dev] [PATCH] doc: Update INSTALL.Docker.md to reflect
> it's focus on OVN
> Sent by: "dev" <dev-bounces@openvswitch.org>
>
> While reading this document, the title stood out to me as not
> accurate. The title indicates it will discuss how to use
> Open vSwitch with Docker, but in reality, it's about using
> Open Virtual Networking with Docker.
>
> This change updates the title, as well as the opening paragraphs
> to more accurately reflect what the document is talking about.
>
> Signed-off-by: Kyle Mestery <mestery@mestery.com>
> ---
>  INSTALL.Docker.md | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
> index b7ca4ba..08758ae 100644
> --- a/INSTALL.Docker.md
> +++ b/INSTALL.Docker.md
> @@ -1,14 +1,11 @@
> -How to Use Open vSwitch with Docker
> -====================================
> -
> -This document describes how to use Open vSwitch with Docker 1.9.0 or
> -later.  This document assumes that you installed Open vSwitch by
following
> -[INSTALL.md] or by using the distribution packages such as .deb or .rpm.
> -Consult www.docker.com for instructions on how to install Docker.
> -
> -Docker 1.9.0 comes with support for multi-host networking.  Integration
> -of Docker networking and Open vSwitch can be achieved via Open vSwitch
> -virtual network (OVN).
> +How to Use Open Virtual Networking With Docker
> +==============================================
> +
> +This document describes how to use Open Virtual Networking with Docker
> +1.9.0 or later.  This document assumes that you have installed Open
> +vSwitch by following [INSTALL.md] or by using hte distribution packages
> +such as .deb or.rpm. Consult www.docker.com for instructions on how to
> +install Docker.  Docker 1.9.0 comes with support for multi-host
networkign.
>
>
>  Setup

lgtm, opening the potential mosh pit via...

Acked-by: Ryan Moats <rmoats@us.ibm.com>
Russell Bryant July 27, 2016, 9:14 p.m. UTC | #2
On Wed, Jul 27, 2016 at 1:40 PM, Kyle Mestery <mestery@mestery.com> wrote:

> While reading this document, the title stood out to me as not
> accurate. The title indicates it will discuss how to use
> Open vSwitch with Docker, but in reality, it's about using
> Open Virtual Networking with Docker.
>
> This change updates the title, as well as the opening paragraphs
> to more accurately reflect what the document is talking about.
>
> Signed-off-by: Kyle Mestery <mestery@mestery.com>
>
>
Seems fine to me, but I think Guru should review it.
Gurucharan Shetty July 28, 2016, 1:25 p.m. UTC | #3
On 27 July 2016 at 10:40, Kyle Mestery <mestery@mestery.com> wrote:

> While reading this document, the title stood out to me as not
> accurate. The title indicates it will discuss how to use
> Open vSwitch with Docker, but in reality, it's about using
> Open Virtual Networking with Docker.
>
> This change updates the title, as well as the opening paragraphs
> to more accurately reflect what the document is talking about.
>
> Signed-off-by: Kyle Mestery <mestery@mestery.com>
>
Thank you! I fixed a couple of typos and applied this.


> ---
>  INSTALL.Docker.md | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
> index b7ca4ba..08758ae 100644
> --- a/INSTALL.Docker.md
> +++ b/INSTALL.Docker.md
> @@ -1,14 +1,11 @@
> -How to Use Open vSwitch with Docker
> -====================================
> -
> -This document describes how to use Open vSwitch with Docker 1.9.0 or
> -later.  This document assumes that you installed Open vSwitch by following
> -[INSTALL.md] or by using the distribution packages such as .deb or .rpm.
> -Consult www.docker.com for instructions on how to install Docker.
> -
> -Docker 1.9.0 comes with support for multi-host networking.  Integration
> -of Docker networking and Open vSwitch can be achieved via Open vSwitch
> -virtual network (OVN).
> +How to Use Open Virtual Networking With Docker
> +==============================================
> +
> +This document describes how to use Open Virtual Networking with Docker
> +1.9.0 or later.  This document assumes that you have installed Open
> +vSwitch by following [INSTALL.md] or by using hte distribution packages
> +such as .deb or.rpm. Consult www.docker.com for instructions on how to
> +install Docker.  Docker 1.9.0 comes with support for multi-host
> networkign.
>
>
>  Setup
> --
> 2.7.4 (Apple Git-66)
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
diff mbox

Patch

diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
index b7ca4ba..08758ae 100644
--- a/INSTALL.Docker.md
+++ b/INSTALL.Docker.md
@@ -1,14 +1,11 @@ 
-How to Use Open vSwitch with Docker
-====================================
-
-This document describes how to use Open vSwitch with Docker 1.9.0 or
-later.  This document assumes that you installed Open vSwitch by following
-[INSTALL.md] or by using the distribution packages such as .deb or .rpm.
-Consult www.docker.com for instructions on how to install Docker.
-
-Docker 1.9.0 comes with support for multi-host networking.  Integration
-of Docker networking and Open vSwitch can be achieved via Open vSwitch
-virtual network (OVN).
+How to Use Open Virtual Networking With Docker
+==============================================
+
+This document describes how to use Open Virtual Networking with Docker
+1.9.0 or later.  This document assumes that you have installed Open
+vSwitch by following [INSTALL.md] or by using hte distribution packages
+such as .deb or.rpm. Consult www.docker.com for instructions on how to
+install Docker.  Docker 1.9.0 comes with support for multi-host networkign.
 
 
 Setup