diff mbox

[ovs-dev] ovsdb: Fix memory leak reported by Valgrind.

Message ID 1469589156-11452-1-git-send-email-u9012063@gmail.com
State Accepted
Headers show

Commit Message

William Tu July 27, 2016, 3:12 a.m. UTC 
Valgrind testcase 1967: simple idl, conditional, modify as delete due
to condition - C reports the following leak:
    json_array_create_empty (json.c:185)
    json_parser_push_array (json.c:1234)
    json_parser_input (json.c:1328)
    json_lex_input (json.c:945)
    json_parser_feed (json.c:1103)
    json_from_string (json.c:1025)
    parse_json (test-ovsdb.c:227)
    update_conditions (test-ovsdb.c:2324)
    do_idl (test-ovsdb.c:2389)
    ovs_cmdl_run_command (command-line.c:121)
    main (test-ovsdb.c:73)

Signed-off-by: William Tu <u9012063@gmail.com>
---
 tests/test-ovsdb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ben Pfaff July 27, 2016, 9:56 p.m. UTC | #1 
On Tue, Jul 26, 2016 at 08:12:36PM -0700, William Tu wrote:
> Valgrind testcase 1967: simple idl, conditional, modify as delete due
> to condition - C reports the following leak:
>     json_array_create_empty (json.c:185)
>     json_parser_push_array (json.c:1234)
>     json_parser_input (json.c:1328)
>     json_lex_input (json.c:945)
>     json_parser_feed (json.c:1103)
>     json_from_string (json.c:1025)
>     parse_json (test-ovsdb.c:227)
>     update_conditions (test-ovsdb.c:2324)
>     do_idl (test-ovsdb.c:2389)
>     ovs_cmdl_run_command (command-line.c:121)
>     main (test-ovsdb.c:73)
> 
> Signed-off-by: William Tu <u9012063@gmail.com>

Thanks, applied.

I changed "ovsdb:" to "test-ovsdb:" in the title to emphasize that this
is just a leak in a test case.
diff mbox

Patch

diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c
index c21001e..4a68bca 100644
--- a/tests/test-ovsdb.c
+++ b/tests/test-ovsdb.c
@@ -2344,6 +2344,7 @@  update_conditions(struct ovsdb_idl *idl, char *commands)
                 parse_link2_json_clause(idl, add_cmd, json->u.array.elems[i]);
             }
         }
+        json_destroy(json);
     }
 }