From patchwork Tue Jul 26 06:02:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zong Kai LI X-Patchwork-Id: 652601 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rz6wc0X4Yz9t0X for ; Tue, 26 Jul 2016 16:02:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=BJabIgSr; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 64CDD10A02; Mon, 25 Jul 2016 23:02:38 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 0E54B108F8 for ; Mon, 25 Jul 2016 23:02:38 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id 94DEF1E0394 for ; Tue, 26 Jul 2016 00:02:37 -0600 (MDT) X-ASG-Debug-ID: 1469512957-09eadd4649549b10001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar5.cudamail.com with ESMTP id s9FRv7jwPYUXaTNl (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 26 Jul 2016 00:02:37 -0600 (MDT) X-Barracuda-Envelope-From: zealokii@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO mail-io0-f195.google.com) (209.85.223.195) by mx1-pf2.cudamail.com with ESMTPS (AES128-SHA encrypted); 26 Jul 2016 06:02:36 -0000 Received-SPF: pass (mx1-pf2.cudamail.com: SPF record at _netblocks.google.com designates 209.85.223.195 as permitted sender) X-Barracuda-RBL-Trusted-Forwarder: 209.85.223.195 Received: by mail-io0-f195.google.com with SMTP id q83so14309248iod.2 for ; Mon, 25 Jul 2016 23:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=yXyKCF6j0LPHbI+Pe2L7m9JThNguejaCyc14NbUoNDg=; b=BJabIgSryWNd5DUyIlALexk8UYHJRPyHlEG5g+efZbv2oHHWkCkdTwdfScc9woWbTf xbutYCSMt4as9L/Vh84h/jMOwjTJlPEyyLmo0CjBorMlce2KjZjRka1CDSz3Y5UPhUJD AAMoI3PLDTWsaA02MZPSy0v0wStquO2hhR7vzTn/nRkawHzr56w0sXl0RSHMRIrMWpO3 b2ArEXZRgKhdnAhXx4AjJQf4OXrobn/pZG09WmA5KI7tp7AH5ZMTUhzC9xjayvNHW8mX KkKQ3rPM9QC9upRSAku5qI//wdvUCrFfN/kaXVBkufs31QtnNFBJyUanWKhtGcQQ0EeU UyOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yXyKCF6j0LPHbI+Pe2L7m9JThNguejaCyc14NbUoNDg=; b=dKczhAg0sBE2dKhRCnk5rVhbmjVGYRjvhqVYqX6RAt0BVnhgeyAKP8ErCNfMT1BqVK +OcgeJGdGAzRIXBlsLq7kstIDgncWPOO0ts4BNQDaJLdNM4YI8oADKQvN1jYa/mwcNHy YAvlrMqp9Abet+dGmFdP+95WN1DCO4fUtckn0+j/fYOYR2akS9Tpj+uMyL2eqJy5Lolx lMpw+qtocju2rDyJZje4M6uyq+neM17XZFBO+93+fgfjskRr6KOVHqKukUByB6BBIpXR qEYgKECEiWZsqkwfcmZfYQDNFgjA2jeKN0AnBAoOMpkcM1J4Aw5Zkj7ms7FyFiNu85nZ H/wA== X-Gm-Message-State: AEkoousHHyV1ia/TxeMRhifuto3WzGWvPN2b57rlKJ1IxQOnIp7s2sGNiX3hwZGhhc4L6Q== X-Received: by 10.157.46.97 with SMTP id c30mr10934309otd.14.1469512955733; Mon, 25 Jul 2016 23:02:35 -0700 (PDT) Received: from localhost.localdomain ([106.38.0.69]) by smtp.gmail.com with ESMTPSA id w76sm12886065ota.40.2016.07.25.23.02.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Jul 2016 23:02:35 -0700 (PDT) X-CudaMail-Envelope-Sender: zealokii@gmail.com From: Zong Kai LI To: dev@openvswitch.org X-CudaMail-MID: CM-E2-725000068 X-CudaMail-DTE: 072616 X-CudaMail-Originating-IP: 209.85.223.195 Date: Tue, 26 Jul 2016 14:02:26 +0800 X-ASG-Orig-Subj: [##CM-E2-725000068##][PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder Message-Id: <1469512946-19732-1-git-send-email-zealokii@gmail.com> X-Mailer: git-send-email 1.9.1 X-GBUdb-Analysis: 0, 209.85.223.195, Ugly c=0.396759 p=-0.191489 Source Normal X-MessageSniffer-Rules: 0-0-0-4299-c X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1469512957 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, DKIM_SIGNED, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.31527 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Subject: [ovs-dev] [PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" It missed comma as constant seperator in match string for ND responder. Signed-off-by: Zong Kai LI --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index a3d1672..8e5c5c5 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -2018,7 +2018,7 @@ build_lswitch_flows(struct hmap *datapaths, struct hmap *ports, } else { ds_put_format(&match, "nd.target == {"); for (size_t j = 0; j < op->lsp_addrs[i].n_ipv6_addrs; j++) { - ds_put_cstr(&match, + ds_put_format(&match, "%s, ", op->lsp_addrs[i].ipv6_addrs[j].addr_s); } ds_chomp(&match, ' ');