diff mbox

[ovs-dev,RFC,3/5] netdev-vport: don't use system type when opening netdev

Message ID 1468861225-8569-4-git-send-email-cascardo@redhat.com
State RFC
Headers show

Commit Message

Thadeu Lima de Souza Cascardo July 18, 2016, 5 p.m. UTC 
tunnel_check_status_change__ calls netdev_open with type system. Using NULL
instead will default to system in case the device is not opened yet, and allow a
different type in case it's already opened.

Any type should be fine, as netdev_get_carrier will work with any of them.
---
 lib/netdev-vport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 83a795c..87a30f8 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -274,7 +274,7 @@  tunnel_check_status_change__(struct netdev_vport *netdev)
     if (ovs_router_lookup(route, iface, NULL, &gw)) {
         struct netdev *egress_netdev;
 
-        if (!netdev_open(iface, "system", &egress_netdev)) {
+        if (!netdev_open(iface, NULL, &egress_netdev)) {
             status = netdev_get_carrier(egress_netdev);
             netdev_close(egress_netdev);
         }