diff mbox

[ovs-dev] ovn-northd: Use ovs_be32 for an IP address in find_lrp_member_ip().

Message ID 1468440179-8426-1-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff July 13, 2016, 8:02 p.m. UTC 
Fixes a number of warnings from "sparse".

Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical router port.")
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 ovn/northd/ovn-northd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gurucharan Shetty July 13, 2016, 8:10 p.m. UTC | #1 
On 13 July 2016 at 13:02, Ben Pfaff <blp@ovn.org> wrote:

> Fixes a number of warnings from "sparse".
>
> Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical
> router port.")
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>
Acked-by: Gurucharan Shetty <guru@ovn.org>


> ---
>  ovn/northd/ovn-northd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> index b262e86..eacae7c 100644
> --- a/ovn/northd/ovn-northd.c
> +++ b/ovn/northd/ovn-northd.c
> @@ -2037,7 +2037,7 @@ lrport_is_enabled(const struct
> nbrec_logical_router_port *lrport)
>  static const char *
>  find_lrp_member_ip(const struct ovn_port *op, const char *ip_s)
>  {
> -    uint32_t ip;
> +    ovs_be32 ip;
>
>      if (!ip_parse(ip_s, &ip)) {
>          static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
> --
> 2.1.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
Ben Pfaff July 13, 2016, 8:37 p.m. UTC | #2 
On Wed, Jul 13, 2016 at 01:10:01PM -0700, Guru Shetty wrote:
> On 13 July 2016 at 13:02, Ben Pfaff <blp@ovn.org> wrote:
> 
> > Fixes a number of warnings from "sparse".
> >
> > Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical
> > router port.")
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> >
> Acked-by: Gurucharan Shetty <guru@ovn.org>

Thanks, applied to master.
diff mbox

Patch

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index b262e86..eacae7c 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -2037,7 +2037,7 @@  lrport_is_enabled(const struct nbrec_logical_router_port *lrport)
 static const char *
 find_lrp_member_ip(const struct ovn_port *op, const char *ip_s)
 {
-    uint32_t ip;
+    ovs_be32 ip;
 
     if (!ip_parse(ip_s, &ip)) {
         static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);