| Message ID | 1468337757-7616-1-git-send-email-aserdean@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Delegated to: | Guru Shetty |
| Headers | show |
Hi Alin! I think that the same fix can be applied to " daemon --detach --monitor startup errors" Acked-by: Paul Boca <pboca@cloudbasesolutions.com> > -----Original Message----- > From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 12, 2016 6:36 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] tests: daemon specific tests > > Testing out the named pipe implementation revealed a problem in > "daemon --detach startup errors". If the daemon actually started nobody > is stopping it. > In the case of test failure kill the daemon. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > --- > tests/daemon.at | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/daemon.at b/tests/daemon.at > index 8f88987..cf95cde 100644 > --- a/tests/daemon.at > +++ b/tests/daemon.at > @@ -153,7 +153,8 @@ AT_CLEANUP > AT_SETUP([daemon --detach startup errors]) > AT_CAPTURE_FILE([pid]) > OVSDB_INIT([db]) > -AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid -- > unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr]) > +AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid -- > unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr], > + [kill `cat pid`]) > AT_CHECK([grep 'ovsdb-server: could not initialize control socket' stderr], > [0], [ignore], []) > AT_CHECK([test ! -s pid]) > -- > 1.9.5.msysgit.0 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
Seems like "daemon --detach --monitor startup errors" is disabled on Windows. Disregard my last comment. Thanks, Paul > -----Original Message----- > From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Paul Boca > Sent: Tuesday, July 12, 2016 8:55 PM > To: Alin Serdean; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] tests: daemon specific tests > > Hi Alin! > > I think that the same fix can be applied to " daemon --detach --monitor > startup errors" > > Acked-by: Paul Boca <pboca@cloudbasesolutions.com> > > > -----Original Message----- > > From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Alin > Serdean > > Sent: Tuesday, July 12, 2016 6:36 PM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [PATCH] tests: daemon specific tests > > > > Testing out the named pipe implementation revealed a problem in > > "daemon --detach startup errors". If the daemon actually started nobody > > is stopping it. > > In the case of test failure kill the daemon. > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > > --- > > tests/daemon.at | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tests/daemon.at b/tests/daemon.at > > index 8f88987..cf95cde 100644 > > --- a/tests/daemon.at > > +++ b/tests/daemon.at > > @@ -153,7 +153,8 @@ AT_CLEANUP > > AT_SETUP([daemon --detach startup errors]) > > AT_CAPTURE_FILE([pid]) > > OVSDB_INIT([db]) > > -AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid -- > > unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr]) > > +AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid -- > > unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr], > > + [kill `cat pid`]) > > AT_CHECK([grep 'ovsdb-server: could not initialize control socket' stderr], > > [0], [ignore], []) > > AT_CHECK([test ! -s pid]) > > -- > > 1.9.5.msysgit.0 > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
On 12 July 2016 at 08:36, Alin Serdean <aserdean@cloudbasesolutions.com> wrote: > Testing out the named pipe implementation revealed a problem in > "daemon --detach startup errors". If the daemon actually started nobody > is stopping it. > In the case of test failure kill the daemon. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > Thank you, applied! > --- > tests/daemon.at | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/daemon.at b/tests/daemon.at > index 8f88987..cf95cde 100644 > --- a/tests/daemon.at > +++ b/tests/daemon.at > @@ -153,7 +153,8 @@ AT_CLEANUP > AT_SETUP([daemon --detach startup errors]) > AT_CAPTURE_FILE([pid]) > OVSDB_INIT([db]) > -AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid > --unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr]) > +AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid > --unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr], > + [kill `cat pid`]) > AT_CHECK([grep 'ovsdb-server: could not initialize control socket' > stderr], > [0], [ignore], []) > AT_CHECK([test ! -s pid]) > -- > 1.9.5.msysgit.0 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
diff --git a/tests/daemon.at b/tests/daemon.at index 8f88987..cf95cde 100644 --- a/tests/daemon.at +++ b/tests/daemon.at @@ -153,7 +153,8 @@ AT_CLEANUP AT_SETUP([daemon --detach startup errors]) AT_CAPTURE_FILE([pid]) OVSDB_INIT([db]) -AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid --unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr]) +AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid --unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr], + [kill `cat pid`]) AT_CHECK([grep 'ovsdb-server: could not initialize control socket' stderr], [0], [ignore], []) AT_CHECK([test ! -s pid])
Testing out the named pipe implementation revealed a problem in "daemon --detach startup errors". If the daemon actually started nobody is stopping it. In the case of test failure kill the daemon. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- tests/daemon.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)