diff mbox

[ovs-dev,V6,07/17] python tests: Skip TCP6 idl tests on Windows

Message ID 1467808691-17280-8-git-send-email-pboca@cloudbasesolutions.com
State Superseded
Delegated to: Guru Shetty
Headers show

Commit Message

Paul Boca July 6, 2016, 12:38 p.m. UTC
TCP6 sockets are not supported in python on Windows.

Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
---
 tests/ovsdb-idl.at | 1 +
 1 file changed, 1 insertion(+)

Comments

Alin Serdean July 6, 2016, 6:31 p.m. UTC | #1
We discussed this issue offline root cause seems to be:
https://bugs.python.org/issue6926
https://github.com/openvswitch/ovs/blob/master/python/ovs/socket_util.py#L309

Needs a commit message update.

Otherwise:
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>



> -----Mesaj original-----

> De la: dev [mailto:dev-bounces@openvswitch.org] În numele Paul Boca

> Trimis: Wednesday, July 6, 2016 3:38 PM

> Către: dev@openvswitch.org

> Subiect: [ovs-dev] [PATCH V6 07/17] python tests: Skip TCP6 idl tests on

> Windows

> 

> TCP6 sockets are not supported in python on Windows.

> 

> Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>

> ---

> V2: No changes

> V3: No changes

> V4: No changes

> V5: No changes

> V6: No changes

> ---

>  tests/ovsdb-idl.at | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index cda0f79..4d16230

> 100644

> --- a/tests/ovsdb-idl.at

> +++ b/tests/ovsdb-idl.at

> @@ -109,6 +109,7 @@ m4_define([OVSDB_CHECK_IDL_TCP_PY],

>  m4_define([OVSDB_CHECK_IDL_TCP6_PYN],

>    [AT_SETUP([$1 - tcp6])

>     AT_SKIP_IF([test $7 = no])

> +   AT_SKIP_IF([test "$IS_WIN32" = "yes"])

>     AT_SKIP_IF([test $HAVE_IPV6 = no])

>     AT_KEYWORDS([ovsdb server idl positive Python with tcp6 socket $5])

>     AT_CHECK([ovsdb-tool create db $abs_srcdir/idltest.ovsschema],

> --

> 2.7.2.windows.1

> _______________________________________________

> dev mailing list

> dev@openvswitch.org

> http://openvswitch.org/mailman/listinfo/dev
diff mbox

Patch

diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at
index cda0f79..4d16230 100644
--- a/tests/ovsdb-idl.at
+++ b/tests/ovsdb-idl.at
@@ -109,6 +109,7 @@  m4_define([OVSDB_CHECK_IDL_TCP_PY],
 m4_define([OVSDB_CHECK_IDL_TCP6_PYN],
   [AT_SETUP([$1 - tcp6])
    AT_SKIP_IF([test $7 = no])
+   AT_SKIP_IF([test "$IS_WIN32" = "yes"])
    AT_SKIP_IF([test $HAVE_IPV6 = no])
    AT_KEYWORDS([ovsdb server idl positive Python with tcp6 socket $5])
    AT_CHECK([ovsdb-tool create db $abs_srcdir/idltest.ovsschema],