| Message ID | 1467808691-17280-16-git-send-email-pboca@cloudbasesolutions.com |
|---|---|
| State | Superseded |
| Delegated to: | Guru Shetty |
| Headers | show |
Just out of curiosity why is this test is skipped on Windows? Since this patch was skipped thus far I will acknowledge the patch and we can fix the test if we can in another. Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Thanks, Alin. > -----Mesaj original----- > De la: dev [mailto:dev-bounces@openvswitch.org] În numele Paul Boca > Trimis: Wednesday, July 6, 2016 3:39 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V6 15/17] python tests: Skip ovn-controller-vtep > tests on Windows > > The tests are not intended to run on Windows. > Until now they were skipped based on $HAVE_PYTHON only. > > Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> > --- > V3: Initial commit > V4: No changes > V5: No changes > V6: No changes > --- > tests/ovn-controller-vtep.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index > 4bbda73..bc56e66 100644 > --- a/tests/ovn-controller-vtep.at > +++ b/tests/ovn-controller-vtep.at > @@ -16,6 +16,7 @@ m4_define([OVN_CONTROLLER_VTEP_START], > AT_KEYWORDS([ovn]) > # this will cause skip when 'make check' using Windows setup. > AT_SKIP_IF([test $HAVE_PYTHON = no]) [Alin Gabriel Serdean: ] You could remove the above I looked over the test and I haven't seen it using python (although maybe I overlooked it). > + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) > > dnl Create databases (ovn-nb, ovn-sb, vtep). > AT_CHECK([ovsdb-tool create vswitchd.db > $abs_top_srcdir/vswitchd/vswitch.ovsschema]) > -- > 2.7.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index 4bbda73..bc56e66 100644 --- a/tests/ovn-controller-vtep.at +++ b/tests/ovn-controller-vtep.at @@ -16,6 +16,7 @@ m4_define([OVN_CONTROLLER_VTEP_START], AT_KEYWORDS([ovn]) # this will cause skip when 'make check' using Windows setup. AT_SKIP_IF([test $HAVE_PYTHON = no]) + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) dnl Create databases (ovn-nb, ovn-sb, vtep). AT_CHECK([ovsdb-tool create vswitchd.db $abs_top_srcdir/vswitchd/vswitch.ovsschema])
The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> --- V3: Initial commit V4: No changes V5: No changes V6: No changes --- tests/ovn-controller-vtep.at | 1 + 1 file changed, 1 insertion(+)