| Message ID | 1466943136-10812-18-git-send-email-pboca@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Delegated to: | Guru Shetty |
| Headers | show |
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > -----Mesaj original----- > De la: dev [mailto:dev-bounces@openvswitch.org] În numele Paul Boca > Trimis: Sunday, June 26, 2016 3:12 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V4 17/20] ovs-ofctl.at: Prevent msys from getting > confused with ipv6 address. > > msys converts ::0/0 into ;c:\MinGW\msys\1.0\1. > > To prevent this, use fullform ipv6 address of the form 0:0:0:0:0:0:0:1 instead. > > Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> > --- > V3: Initial commit > V4: No changes > --- > tests/ovn-nbctl.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at index 91d482b..fd67c6d > 100644 > --- a/tests/ovn-nbctl.at > +++ b/tests/ovn-nbctl.at > @@ -407,7 +407,7 @@ AT_CHECK([ovn-nbctl lr-route-list lr0], [0], [dnl > ]) > > dnl Check IPv6 routes > -AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1]) > +AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 > +2001:0db8:0:f101::1]) > AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 > lp0]) AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 > 2001:0db8:0:f103::1]) > > @@ -434,7 +434,7 @@ dnl Check IPv4 and IPv6 routes AT_CHECK([ovn-nbctl > lr-route-add lr0 0.0.0.0/0 192.168.0.1]) AT_CHECK([ovn-nbctl lr-route-add lr0 > 10.0.1.1/24 11.0.1.1 lp0]) AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.0.1/24 > 11.0.0.1]) -AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1]) > +AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 > +2001:0db8:0:f101::1]) > AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 > lp0]) AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 > 2001:0db8:0:f103::1]) > > -- > 2.7.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
On 26 June 2016 at 05:12, Paul Boca <pboca@cloudbasesolutions.com> wrote: > msys converts ::0/0 into ;c:\MinGW\msys\1.0\1. > > To prevent this, use fullform ipv6 address of the form 0:0:0:0:0:0:0:1 > instead. > Isn't the fullform of ::0/0 0:0:0:0:0:0:0:0/0 and not 0:0:0:0:0:0:0:1/0 ? > > Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> > --- > V3: Initial commit > V4: No changes > --- > tests/ovn-nbctl.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at > index 91d482b..fd67c6d 100644 > --- a/tests/ovn-nbctl.at > +++ b/tests/ovn-nbctl.at > @@ -407,7 +407,7 @@ AT_CHECK([ovn-nbctl lr-route-list lr0], [0], [dnl > ]) > > dnl Check IPv6 routes > -AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1]) > +AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 > 2001:0db8:0:f101::1]) > AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 > lp0]) > AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 > 2001:0db8:0:f103::1]) > > @@ -434,7 +434,7 @@ dnl Check IPv4 and IPv6 routes > AT_CHECK([ovn-nbctl lr-route-add lr0 0.0.0.0/0 192.168.0.1]) > AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.1.1/24 11.0.1.1 lp0]) > AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.0.1/24 11.0.0.1]) > -AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1]) > +AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 > 2001:0db8:0:f101::1]) > AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 > lp0]) > AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 > 2001:0db8:0:f103::1]) > > -- > 2.7.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at index 91d482b..fd67c6d 100644 --- a/tests/ovn-nbctl.at +++ b/tests/ovn-nbctl.at @@ -407,7 +407,7 @@ AT_CHECK([ovn-nbctl lr-route-list lr0], [0], [dnl ]) dnl Check IPv6 routes -AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1]) +AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 2001:0db8:0:f101::1]) AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 lp0]) AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 2001:0db8:0:f103::1]) @@ -434,7 +434,7 @@ dnl Check IPv4 and IPv6 routes AT_CHECK([ovn-nbctl lr-route-add lr0 0.0.0.0/0 192.168.0.1]) AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.1.1/24 11.0.1.1 lp0]) AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.0.1/24 11.0.0.1]) -AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1]) +AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 2001:0db8:0:f101::1]) AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 lp0]) AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 2001:0db8:0:f103::1])
msys converts ::0/0 into ;c:\MinGW\msys\1.0\1. To prevent this, use fullform ipv6 address of the form 0:0:0:0:0:0:0:1 instead. Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> --- V3: Initial commit V4: No changes --- tests/ovn-nbctl.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)