diff mbox

[ovs-dev,V3,20/21] tests: Skip vlog tests that try to move opened file

Message ID 1466680602-18584-21-git-send-email-pboca@cloudbasesolutions.com
State Superseded
Delegated to: Guru Shetty
Headers show

Commit Message

Paul Boca June 23, 2016, 11:17 a.m. UTC 
On Windows if a file is opened by an application for writing, we cannot move
it until all handles to that file are closed.

Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
---
V3: Initial commit
---
 tests/vlog.at | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox

Patch

diff --git a/tests/vlog.at b/tests/vlog.at
index c260b5e..682b42c 100644
--- a/tests/vlog.at
+++ b/tests/vlog.at
@@ -148,6 +148,9 @@  AT_CLEANUP
 
 m4_define([VLOG_REOPEN_PYN],
   [AT_SETUP([vlog - vlog/reopen - $1])
+   # This test won't work as-is on Windows because Windows doesn't allow
+   # files that are open to be renamed.
+   AT_SKIP_IF([test "$IS_WIN32" = "yes"])
    AT_SKIP_IF([test $2 = no])
    on_exit 'kill `cat test-unixctl.py.pid`'
 
@@ -315,6 +318,9 @@  AT_CLEANUP
 
 m4_define([VLOG_CLOSE_PYN],
   [AT_SETUP([vlog - vlog/close - $1])
+   # This test won't work as-is on Windows because Windows doesn't allow
+   # files that are open to be renamed.
+   AT_SKIP_IF([test "$IS_WIN32" = "yes"])
    AT_SKIP_IF([test $2 = no])
    on_exit 'kill `cat test-unixctl.py.pid`'