From patchwork Thu Jun 9 20:24:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nirapada Ghosh X-Patchwork-Id: 633442 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rQhY563CWz9sD5 for ; Fri, 10 Jun 2016 09:37:13 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id C558A22C3EC; Thu, 9 Jun 2016 16:36:57 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id BFFCF10B66 for ; Thu, 9 Jun 2016 13:24:22 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id 4EAC51E009C for ; Thu, 9 Jun 2016 14:24:22 -0600 (MDT) X-ASG-Debug-ID: 1465503861-09eadd2ece2a070001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar5.cudamail.com with ESMTP id kMOaQzeg68mB4iSC (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 09 Jun 2016 14:24:21 -0600 (MDT) X-Barracuda-Envelope-From: nirapada@host.local.domain X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by mx1-pf2.cudamail.com with ESMTPS (AES256-SHA encrypted); 9 Jun 2016 20:24:21 -0000 Received-SPF: none (mx1-pf2.cudamail.com: domain at host.local.domain does not designate permitted sender hosts) X-Barracuda-Apparent-Source-IP: 148.163.158.5 X-Barracuda-RBL-IP: 148.163.158.5 Received: from pps.filterd (m0049461.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u59KNWXP028545 for ; Thu, 9 Jun 2016 16:24:19 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 23fa5xqjdk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 09 Jun 2016 16:24:19 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Jun 2016 21:24:17 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 9 Jun 2016 21:24:15 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: nirapada@host.local.domain X-IBM-RcptTo: dev@openvswitch.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 066FB17D8056 for ; Thu, 9 Jun 2016 21:25:26 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u59KOFbG39845890 for ; Thu, 9 Jun 2016 20:24:15 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u59KOEEM001233 for ; Thu, 9 Jun 2016 14:24:14 -0600 Received: from host.local.domain ([9.80.198.114]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u59KODfH001202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Jun 2016 14:24:14 -0600 Received: by host.local.domain (Postfix, from userid 501) id 3E3DC1509A1D; Thu, 9 Jun 2016 13:24:13 -0700 (PDT) X-CudaMail-Envelope-Sender: nirapada@host.local.domain From: nghosh@us.ibm.com To: dev@openvswitch.org X-CudaMail-MID: CM-E2-608072242 X-CudaMail-DTE: 060916 X-CudaMail-Originating-IP: 148.163.158.5 Date: Thu, 9 Jun 2016 13:24:11 -0700 X-ASG-Orig-Subj: [##CM-E2-608072242##][PATCH] Make logging consistent by replacing vlog with ctl_fatal X-Mailer: git-send-email 2.7.4 (Apple Git-66) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16060920-0016-0000-0000-000001F4A26A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16060920-0017-0000-0000-000021DA68AD Message-Id: <1465503851-41877-1-git-send-email-nghosh@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-06-09_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606090224 X-GBUdb-Analysis: 0, 148.163.158.5, Ugly c=0.36638 p=-0.2 Source Normal X-MessageSniffer-Rules: 0-0-0-5923-c X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1465503861 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, NO_REAL_NAME, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.30305 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 X-Mailman-Approved-At: Thu, 09 Jun 2016 16:36:55 -0700 Subject: [ovs-dev] [PATCH] Make logging consistent by replacing vlog with ctl_fatal X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" From: Nirapada Ghosh This change is just a minor cleanup to remove VLOG_WARN from ovn-nbctl.c and use ctl_fatal. I believe, VLOG_WARN is not supposed to be used here. --- ovn/utilities/ovn-nbctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 321040e..8dc5fda 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -1523,11 +1523,11 @@ do_nbctl(const char *args, struct ctl_command *commands, size_t n_commands, } if (!symbol->strong_ref) { if (!symbol->weak_ref) { - VLOG_WARN("row id \"%s\" was created but no reference to it " + ctl_fatal("row id \"%s\" was created but no reference to it " "was inserted, so it will not actually appear in " "the database", node->name); } else { - VLOG_WARN("row id \"%s\" was created but only a weak " + ctl_fatal("row id \"%s\" was created but only a weak " "reference to it was inserted, so it will not " "actually appear in the database", node->name); }