| Message ID | 1465456362-58140-2-git-send-email-jpettit@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
"dev" <dev-bounces@openvswitch.org> wrote on 06/09/2016 02:12:35 AM: > From: Justin Pettit <jpettit@ovn.org> > To: dev@openvswitch.org > Date: 06/09/2016 02:13 AM > Subject: [ovs-dev] [PATCH 1/8] ovn-nbctl: Use "ctx->output" instead > of printf for list ACLs. > Sent by: "dev" <dev-bounces@openvswitch.org> > > Signed-off-by: Justin Pettit <jpettit@ovn.org> > --- > ovn/utilities/ovn-nbctl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c > index 321040e..7672952 100644 > --- a/ovn/utilities/ovn-nbctl.c > +++ b/ovn/utilities/ovn-nbctl.c > @@ -1292,8 +1292,9 @@ nbctl_acl_list(struct ctl_context *ctx) > > for (i = 0; i < lswitch->n_acls; i++) { > const struct nbrec_acl *acl = acls[i]; > - printf("%10s %5"PRId64" (%s) %s%s\n", acl->direction, acl-> priority, > - acl->match, acl->action, acl->log ? " log" : ""); > + ds_put_format(&ctx->output, "%10s %5"PRId64" (%s) %s%s\n", > + acl->direction, acl->priority, > + acl->match, acl->action, acl->log ? " log" : ""); > } > > free(acls); > -- > 1.9.1 This one is simple enough so Acked-by: Ryan Moats <rmoats@us.ibm.com> Will try and look at the others later today (no promises though)
On Thu, Jun 09, 2016 at 12:12:35AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpettit@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 321040e..7672952 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -1292,8 +1292,9 @@ nbctl_acl_list(struct ctl_context *ctx) for (i = 0; i < lswitch->n_acls; i++) { const struct nbrec_acl *acl = acls[i]; - printf("%10s %5"PRId64" (%s) %s%s\n", acl->direction, acl->priority, - acl->match, acl->action, acl->log ? " log" : ""); + ds_put_format(&ctx->output, "%10s %5"PRId64" (%s) %s%s\n", + acl->direction, acl->priority, + acl->match, acl->action, acl->log ? " log" : ""); } free(acls);
Signed-off-by: Justin Pettit <jpettit@ovn.org> --- ovn/utilities/ovn-nbctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)