diff mbox

[ovs-dev] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

Message ID 1460965940-6856-1-git-send-email-pboca@cloudbasesolutions.com
State Superseded
Headers show

Commit Message

Paul Boca April 18, 2016, 7:52 a.m. UTC 
nicParam->PermanentMacAddress is 32 bytes and vport->permMacAddress is 6 bytes

Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
---
 datapath-windows/ovsext/DpInternal.h | 6 +++---
 datapath-windows/ovsext/Vport.h      | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
diff mbox

Patch

diff --git a/datapath-windows/ovsext/DpInternal.h b/datapath-windows/ovsext/DpInternal.h
index a3ce311..760552d 100644
--- a/datapath-windows/ovsext/DpInternal.h
+++ b/datapath-windows/ovsext/DpInternal.h
@@ -41,9 +41,9 @@  typedef struct _OVS_VPORT_GET {
 typedef struct _OVS_VPORT_EXT_INFO {
     uint32_t dpNo;
     uint32_t portNo;
-    uint8_t macAddress[ETH_ADDR_LEN];
-    uint8_t permMACAddress[ETH_ADDR_LEN];
-    uint8_t vmMACAddress[ETH_ADDR_LEN];
+    uint8_t macAddress[NDIS_MAX_PHYS_ADDRESS_LENGTH];
+    uint8_t permMACAddress[NDIS_MAX_PHYS_ADDRESS_LENGTH];
+    uint8_t vmMACAddress[NDIS_MAX_PHYS_ADDRESS_LENGTH];
     uint16_t nicIndex;
     uint32_t portId;
     uint32_t type;
diff --git a/datapath-windows/ovsext/Vport.h b/datapath-windows/ovsext/Vport.h
index 373896d..3f18eb1 100644
--- a/datapath-windows/ovsext/Vport.h
+++ b/datapath-windows/ovsext/Vport.h
@@ -102,9 +102,9 @@  typedef struct _OVS_VPORT_ENTRY {
     NDIS_SWITCH_NIC_STATE  nicState;
     NDIS_SWITCH_PORT_TYPE  portType;
 
-    UINT8                  permMacAddress[ETH_ADDR_LEN];
-    UINT8                  currMacAddress[ETH_ADDR_LEN];
-    UINT8                  vmMacAddress[ETH_ADDR_LEN];
+    UINT8                  permMacAddress[NDIS_MAX_PHYS_ADDRESS_LENGTH];
+    UINT8                  currMacAddress[NDIS_MAX_PHYS_ADDRESS_LENGTH];
+    UINT8                  vmMacAddress[NDIS_MAX_PHYS_ADDRESS_LENGTH];
 
     NDIS_SWITCH_PORT_NAME  hvPortName;
     IF_COUNTED_STRING      portFriendlyName;