| Message ID | 1460764967-110943-2-git-send-email-diproiettod@vmware.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 15 April 2016 at 17:02, Daniele Di Proietto <diproiettod@vmware.com> wrote: > Linux and FreeBSD have slightly different names for these constants. > Windows doesn't define them. It is simpler to redefine them from > scratch for OVS. The new names are different than those used in Linux > and FreeBSD. > > These definitions will be used by a future commit. > > Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> Acked-by: Joe Stringer <joe@ovn.org>
On Fri, Apr 15, 2016 at 05:02:33PM -0700, Daniele Di Proietto wrote: > Linux and FreeBSD have slightly different names for these constants. > Windows doesn't define them. It is simpler to redefine them from > scratch for OVS. The new names are different than those used in Linux > and FreeBSD. > > These definitions will be used by a future commit. > > Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> > --- Acked-by: Flavio Leitner <fbl@sysclose.org>
diff --git a/lib/packets.h b/lib/packets.h index 8139a6b..3ceff99 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -596,9 +596,21 @@ struct ip_header { ovs_16aligned_be32 ip_src; ovs_16aligned_be32 ip_dst; }; - BUILD_ASSERT_DECL(IP_HEADER_LEN == sizeof(struct ip_header)); +/* ICMPv4 types. */ +#define ICMP4_ECHO_REPLY 0 +#define ICMP4_DST_UNREACH 3 +#define ICMP4_SOURCEQUENCH 4 +#define ICMP4_REDIRECT 5 +#define ICMP4_ECHO_REQUEST 8 +#define ICMP4_TIME_EXCEEDED 11 +#define ICMP4_PARAM_PROB 12 +#define ICMP4_TIMESTAMP 13 +#define ICMP4_TIMESTAMPREPLY 14 +#define ICMP4_INFOREQUEST 15 +#define ICMP4_INFOREPLY 16 + #define ICMP_HEADER_LEN 8 struct icmp_header { uint8_t icmp_type;
Linux and FreeBSD have slightly different names for these constants. Windows doesn't define them. It is simpler to redefine them from scratch for OVS. The new names are different than those used in Linux and FreeBSD. These definitions will be used by a future commit. Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> --- lib/packets.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)