diff mbox

[ovs-dev,1/6] Add physical endpts and binding to logical ports to SB schema

Message ID 1458159951-21345-2-git-send-email-dball@vmware.com
State Deferred
Headers show

Commit Message

Darrell Ball March 16, 2016, 8:25 p.m. UTC
Signed-off-by: Darrell Ball <dball@vmware.com>
---
 ovn/ovn-sb.ovsschema | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

Comments

Ben Pfaff March 23, 2016, 4:01 p.m. UTC | #1
On Wed, Mar 16, 2016 at 01:25:46PM -0700, Darrell Ball wrote:
> Signed-off-by: Darrell Ball <dball@vmware.com>

Doesn't build because the documentation wasn't updated:

    ../ovsdb/ovsdb-doc: undocumented table Physical_Endpoint
    Makefile:6126: recipe for target 'ovn/ovn-sb.5' failed
Darrell Ball March 23, 2016, 8:04 p.m. UTC | #2
On 3/23/16, 9:01 AM, "dev on behalf of Ben Pfaff" <dev-bounces@openvswitch.org on behalf of blp@ovn.org> wrote:

>On Wed, Mar 16, 2016 at 01:25:46PM -0700, Darrell Ball wrote:

>> Signed-off-by: Darrell Ball <dball@vmware.com>

>

>Doesn't build because the documentation wasn't updated:

>

>    ../ovsdb/ovsdb-doc: undocumented table Physical_Endpoint

>    Makefile:6126: recipe for target 'ovn/ovn-sb.5' failed


Right, its updated in another patch in the series which was later moved
into the same patch in V2

>_______________________________________________

>dev mailing list

>dev@openvswitch.org

>http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff March 23, 2016, 8:06 p.m. UTC | #3
On Wed, Mar 23, 2016 at 08:04:05PM +0000, Darrell Ball wrote:
> On 3/23/16, 9:01 AM, "dev on behalf of Ben Pfaff" <dev-bounces@openvswitch.org on behalf of blp@ovn.org> wrote:
> 
> >On Wed, Mar 16, 2016 at 01:25:46PM -0700, Darrell Ball wrote:
> >> Signed-off-by: Darrell Ball <dball@vmware.com>
> >
> >Doesn't build because the documentation wasn't updated:
> >
> >    ../ovsdb/ovsdb-doc: undocumented table Physical_Endpoint
> >    Makefile:6126: recipe for target 'ovn/ovn-sb.5' failed
> 
> Right, its updated in another patch in the series which was later moved
> into the same patch in V2

Is this version of the series superseded, then?  Where is v2?
Darrell Ball March 23, 2016, 10:09 p.m. UTC | #4
V2: https://patchwork.ozlabs.org/patch/600174/


This combined all files to eliminate all possible dependencies…. 

I delayed splitting this patch into 2 parts (Physical-Logical and L2 Gateway) because I’m discussing offline
with Russell on a localnet use case and will update the mailing list accordingly afterwards





On 3/23/16, 1:06 PM, "Ben Pfaff" <blp@ovn.org> wrote:

>On Wed, Mar 23, 2016 at 08:04:05PM +0000, Darrell Ball wrote:

>> On 3/23/16, 9:01 AM, "dev on behalf of Ben Pfaff" <dev-bounces@openvswitch.org on behalf of blp@ovn.org> wrote:

>> 

>> >On Wed, Mar 16, 2016 at 01:25:46PM -0700, Darrell Ball wrote:

>> >> Signed-off-by: Darrell Ball <dball@vmware.com>

>> >

>> >Doesn't build because the documentation wasn't updated:

>> >

>> >    ../ovsdb/ovsdb-doc: undocumented table Physical_Endpoint

>> >    Makefile:6126: recipe for target 'ovn/ovn-sb.5' failed

>> 

>> Right, its updated in another patch in the series which was later moved

>> into the same patch in V2

>

>Is this version of the series superseded, then?  Where is v2?
diff mbox

Patch

diff --git a/ovn/ovn-sb.ovsschema b/ovn/ovn-sb.ovsschema
index ead733b..a508ee2 100644
--- a/ovn/ovn-sb.ovsschema
+++ b/ovn/ovn-sb.ovsschema
@@ -1,7 +1,7 @@ 
 {
     "name": "OVN_Southbound",
     "version": "1.1.0",
-    "cksum": "1223981720 5320",
+    "cksum": "3541514154 6375",
     "tables": {
         "Chassis": {
             "columns": {
@@ -70,6 +70,21 @@ 
                              "min": 0, "max": "unlimited"}}},
             "indexes": [["tunnel_key"]],
             "isRoot": true},
+        "Physical_Endpoint": {
+            "columns": {
+                "name": {"type": "string"},
+                "chassis": {"type": {"key": {"type": "uuid",
+                                             "refTable": "Chassis",
+                                             "refType": "weak"},
+                                     "min": 0, "max": 1}},
+                "chassis_port": {"type": {"key": "string", "min": 0, "max": 1}},
+                "type": {"type": {"key": {
+                           "type": "string",
+                           "enum": ["set", ["vlan", "mpls_label_stack", "later"]]}}},
+                "ingress_encap": {"type": "string"},
+                "egress_encap": {"type": "string"}},
+            "indexes": [["name"]],
+            "isRoot": true},
         "Port_Binding": {
             "columns": {
                 "logical_port": {"type": "string"},
@@ -95,6 +110,10 @@ 
                                              "refTable": "Chassis",
                                              "refType": "weak"},
                                      "min": 0, "max": 1}},
+                "phys_endpts": {"type": {"key": {"type": "uuid",
+                                             "refTable": "Physical_Endpoint",
+                                             "refType": "weak"},
+                                     "min": 0, "max": "unlimited"}},
                 "mac": {"type": {"key": "string",
                                  "min": 0,
                                  "max": "unlimited"}}},