| Message ID | 1458131974-4040-3-git-send-email-yamamoto@midokura.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Mar 16, 2016 at 09:39:33PM +0900, YAMAMOTO Takashi wrote: > BRE alternative (\|) is an GNU sed extension. [1] > It isn't available in NetBSD sed. > > [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions > regexp1\|regexp2 > Matches either regexp1 or regexp2. Use parentheses to use > complex alternative regular expressions. The matching process > tries each alternative in turn, from left to right, and the > first one that succeeds is used. It is a GNU extension. > > Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> Oops. Thanks for the fix. Acked-by: Ben Pfaff <blp@ovn.org>
On Thu, Mar 24, 2016 at 12:46 AM, Ben Pfaff <blp@ovn.org> wrote: > On Wed, Mar 16, 2016 at 09:39:33PM +0900, YAMAMOTO Takashi wrote: >> BRE alternative (\|) is an GNU sed extension. [1] >> It isn't available in NetBSD sed. >> >> [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions >> regexp1\|regexp2 >> Matches either regexp1 or regexp2. Use parentheses to use >> complex alternative regular expressions. The matching process >> tries each alternative in turn, from left to right, and the >> first one that succeeds is used. It is a GNU extension. >> >> Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> > > Oops. Thanks for the fix. > > Acked-by: Ben Pfaff <blp@ovn.org> thank you. pushed to master.
diff --git a/tests/vlog.at b/tests/vlog.at index 00ebd92..48ef885 100644 --- a/tests/vlog.at +++ b/tests/vlog.at @@ -359,7 +359,7 @@ AT_CHECK([vlog_filt stderr], [0], [opened log file ]) AT_CHECK([APPCTL -t test-unixctl vlog/list | sed -n '1,2p -/\(test_unixctl\|daemon\) /p'], [0], [dnl +/test_unixctl /p; /daemon /p'], [0], [dnl console syslog file ------- ------ ------ daemon OFF INFO INFO @@ -373,7 +373,7 @@ AT_CHECK([APPCTL -t test-unixctl vlog/set nonexistent], [2], [], ovs-appctl: test-unixctl: server returned an error ]) AT_CHECK([APPCTL -t test-unixctl vlog/list | sed -n '1,2p -/\(test_unixctl\|daemon\) /p'], [0], [dnl +/test_unixctl /p; /daemon /p'], [0], [dnl console syslog file ------- ------ ------ daemon OFF ERR DBG
BRE alternative (\|) is an GNU sed extension. [1] It isn't available in NetBSD sed. [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions regexp1\|regexp2 Matches either regexp1 or regexp2. Use parentheses to use complex alternative regular expressions. The matching process tries each alternative in turn, from left to right, and the first one that succeeds is used. It is a GNU extension. Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> --- tests/vlog.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)