diff mbox

[ovs-dev] netdev-dpdk: Fix memory leak in netdev_dpdk_vhost_destruct().

Message ID 1456993806-3003-1-git-send-email-i.maximets@samsung.com
State Accepted
Headers show

Commit Message

Ilya Maximets March 3, 2016, 8:30 a.m. UTC
Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 lib/netdev-dpdk.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Flavio Leitner March 3, 2016, 12:50 p.m. UTC | #1
On Thu, 03 Mar 2016 11:30:06 +0300
Ilya Maximets <i.maximets@samsung.com> wrote:

> Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support")
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>  lib/netdev-dpdk.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index d21bb4c..0233b3c 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -882,6 +882,7 @@ netdev_dpdk_vhost_destruct(struct netdev *netdev_)
>      }
>  
>      ovs_mutex_lock(&dpdk_mutex);
> +    rte_free(dev->tx_q);
>      list_remove(&dev->list_node);
>      dpdk_mp_put(dev->dpdk_mp);
>      ovs_mutex_unlock(&dpdk_mutex);

Acked-by: Flavio Leitner <fbl@sysclose.org>

This needs to go to branch-2.5 as well.
Thanks Ilya!
Daniele Di Proietto March 6, 2016, 4:19 a.m. UTC | #2
Thanks, I applied this to master and branch-2.5

On 03/03/2016 04:50, "Flavio Leitner" <fbl@sysclose.org> wrote:

>On Thu, 03 Mar 2016 11:30:06 +0300
>Ilya Maximets <i.maximets@samsung.com> wrote:
>
>> Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support")
>> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
>> ---
>>  lib/netdev-dpdk.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>> index d21bb4c..0233b3c 100644
>> --- a/lib/netdev-dpdk.c
>> +++ b/lib/netdev-dpdk.c
>> @@ -882,6 +882,7 @@ netdev_dpdk_vhost_destruct(struct netdev *netdev_)
>>      }
>>  
>>      ovs_mutex_lock(&dpdk_mutex);
>> +    rte_free(dev->tx_q);
>>      list_remove(&dev->list_node);
>>      dpdk_mp_put(dev->dpdk_mp);
>>      ovs_mutex_unlock(&dpdk_mutex);
>
>Acked-by: Flavio Leitner <fbl@sysclose.org>
>
>This needs to go to branch-2.5 as well.
>Thanks Ilya!
>-- 
>fbl
>
diff mbox

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index d21bb4c..0233b3c 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -882,6 +882,7 @@  netdev_dpdk_vhost_destruct(struct netdev *netdev_)
     }
 
     ovs_mutex_lock(&dpdk_mutex);
+    rte_free(dev->tx_q);
     list_remove(&dev->list_node);
     dpdk_mp_put(dev->dpdk_mp);
     ovs_mutex_unlock(&dpdk_mutex);