| Message ID | 1448519457-10446-1-git-send-email-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Nov 25, 2015 at 10:30:57PM -0800, Ben Pfaff wrote: > Found by sparse. > > CC: Jarno Rajahalme <jarno@ovn.org> > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- LGTM Acked-by: Flavio Leitner <fbl@sysclose.org>
On Thu, Nov 26, 2015 at 02:47:21PM -0200, Flavio Leitner wrote: > On Wed, Nov 25, 2015 at 10:30:57PM -0800, Ben Pfaff wrote: > > Found by sparse. > > > > CC: Jarno Rajahalme <jarno@ovn.org> > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > LGTM > Acked-by: Flavio Leitner <fbl@sysclose.org> Thanks. I applied this to master.
Thanks for fixing that Ben. Jarno Jarno > On Nov 26, 2015, at 08:50, Ben Pfaff <blp@ovn.org> wrote: > >> On Thu, Nov 26, 2015 at 02:47:21PM -0200, Flavio Leitner wrote: >>> On Wed, Nov 25, 2015 at 10:30:57PM -0800, Ben Pfaff wrote: >>> Found by sparse. >>> >>> CC: Jarno Rajahalme <jarno@ovn.org> >>> Signed-off-by: Ben Pfaff <blp@ovn.org> >>> --- >> >> LGTM >> Acked-by: Flavio Leitner <fbl@sysclose.org> > > Thanks. I applied this to master. > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index ab4d52f..eeb919d 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -4262,11 +4262,12 @@ put_ct_nat(struct xlate_ctx *ctx) nl_msg_put_flag(ctx->odp_actions, OVS_NAT_ATTR_PROTO_RANDOM); } if (ofn->range_af == AF_INET) { - nl_msg_put_u32(ctx->odp_actions, OVS_NAT_ATTR_IP_MIN, + nl_msg_put_be32(ctx->odp_actions, OVS_NAT_ATTR_IP_MIN, ofn->range.addr.ipv4.min); if (ofn->range.addr.ipv4.max && - ofn->range.addr.ipv4.max > ofn->range.addr.ipv4.min) { - nl_msg_put_u32(ctx->odp_actions, OVS_NAT_ATTR_IP_MAX, + (ntohl(ofn->range.addr.ipv4.max) + > ntohl(ofn->range.addr.ipv4.min))) { + nl_msg_put_be32(ctx->odp_actions, OVS_NAT_ATTR_IP_MAX, ofn->range.addr.ipv4.max); } } else if (ofn->range_af == AF_INET6) {
Found by sparse. CC: Jarno Rajahalme <jarno@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)