diff mbox

[ovs-dev] ovs-ofctl.8: Improve description of dec_ttl action.

Message ID 1447115538-75942-1-git-send-email-jpettit@ovn.org
State Accepted
Headers show

Commit Message

Justin Pettit Nov. 10, 2015, 12:32 a.m. UTC
Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 utilities/ovs-ofctl.8.in |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

Comments

Ben Pfaff Nov. 10, 2015, 4:51 a.m. UTC | #1
On Mon, Nov 09, 2015 at 04:32:18PM -0800, Justin Pettit wrote:
> @@ -1744,9 +1744,10 @@ a ``packet-in'' message with reason code \fBOFPR_INVALID_TTL\fR is
>  sent to each connected controller that has enabled receiving them,
>  if any.  Processing the current set of actions then stops.  However,
>  if the current set of actions was reached through ``resubmit'' then
> -remaining actions in outer levels resume processing.  This action
> -also optionally supports the ability to specify a list of valid
> -controller ids.  Each of controllers in the list will receive the
> +remaining actions in outer levels resume processing.
> +.IP
> +This action also optionally supports the ability to specify a list of
> +valid controller ids.  Each of controllers in the list will receive the

s/of controllers/of the controllers/

Acked-by: Ben Pfaff <blp@ovn.org>
Justin Pettit Nov. 11, 2015, 2:24 a.m. UTC | #2
> On Nov 9, 2015, at 8:51 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> On Mon, Nov 09, 2015 at 04:32:18PM -0800, Justin Pettit wrote:
>> @@ -1744,9 +1744,10 @@ a ``packet-in'' message with reason code \fBOFPR_INVALID_TTL\fR is
>> sent to each connected controller that has enabled receiving them,
>> if any.  Processing the current set of actions then stops.  However,
>> if the current set of actions was reached through ``resubmit'' then
>> -remaining actions in outer levels resume processing.  This action
>> -also optionally supports the ability to specify a list of valid
>> -controller ids.  Each of controllers in the list will receive the
>> +remaining actions in outer levels resume processing.
>> +.IP
>> +This action also optionally supports the ability to specify a list of
>> +valid controller ids.  Each of controllers in the list will receive the
> 
> s/of controllers/of the controllers/
> 
> Acked-by: Ben Pfaff <blp@ovn.org>

Thanks.  I made the fix and pushed to master.

--Justin
diff mbox

Patch

diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index dc81e7e..bfb431f 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -1736,7 +1736,7 @@  nf_conntrack module loaded.
 .RE
 .
 .IP \fBdec_ttl\fR
-.IQ \fBdec_ttl\fB[\fR(\fIid1,id2\fI)\fR]\fR
+.IQ \fBdec_ttl(\fIid1\fR[\fB,\fIid2\fR]...\fB)\fR
 Decrement TTL of IPv4 packet or hop limit of IPv6 packet.  If the
 TTL or hop limit is initially zero or decrementing would make it so, no
 decrement occurs, as packets reaching TTL zero must be rejected.  Instead,
@@ -1744,9 +1744,10 @@  a ``packet-in'' message with reason code \fBOFPR_INVALID_TTL\fR is
 sent to each connected controller that has enabled receiving them,
 if any.  Processing the current set of actions then stops.  However,
 if the current set of actions was reached through ``resubmit'' then
-remaining actions in outer levels resume processing.  This action
-also optionally supports the ability to specify a list of valid
-controller ids.  Each of controllers in the list will receive the
+remaining actions in outer levels resume processing.
+.IP
+This action also optionally supports the ability to specify a list of
+valid controller ids.  Each of controllers in the list will receive the
 ``packet_in'' message only if they have registered to receive the
 invalid ttl packets.  If controller ids are not specified, the
 ``packet_in'' message will be sent only to the controllers having