| Message ID | cover.1732630344.git.felix.huettner@stackit.cloud |
|---|---|
| Headers | show |
| Series | OVS Patches for OVN Fabric Integration | expand |
Hello, Felix, Thank you for continuing the work started in https://mail.openvswitch.org/pipermail/ovs-dev/2024-July/416042.html. On Tue, Nov 26, 2024 at 3:37 PM Felix Huettner via dev <ovs-dev@openvswitch.org> wrote: > > Hi everyone, > > all these patches are needed as part of the OVN fabric integration > patcheset that will hit the mailing list in a few minutes. > They do not intend to change anything for OVS, just for the libraries > OVN uses from OVS. > > Major changes between v1 and v2: > * reduced the amount of changes across unrelated ovs code > * added tests > * support getting the interface name of a route change in a network > namespace This series consists of two orthogonal changes: - Exporting and expanding route-table library code. - Introducing support for handling network namespaces in existing library functions. The first change is well understood and has low potential for issues, and yet it is a prerequisite for the success of introducing a stream of work in OVN for 25.03. The second change introduces new functionality with a higher potential for issues. While I understand and respect that you have a use case for the second change, it is not a prerequisite for the success of the main components of the building blocks we want to get landed in OVN 25.03. Attempting to entangle the two introduces a risk that neither lands in time for OVS 3.5 branching, so I kindly request that you split the work in two independent series, or at least separate the changes so that the introduction of the namespaces feature comes at the end of the series. The series also appears to need a rebase. -- Frode Nordahl > Felix Huettner (6): > netlink: Support accessing namespaces. > netlink-notifier: Support network namespaces. > route-table: Expose data to ovn. > route-table: Expose route_table_parse_ns. > route-table: Support parsing multipath routes. > route-table: Support network namespaces. > > .github/workflows/build-and-test.yml | 2 +- > NEWS | 3 + > lib/netlink-notifier.c | 10 +- > lib/netlink-notifier.h | 8 +- > lib/netlink-socket.c | 122 +++++++++++-- > lib/netlink-socket.h | 9 +- > lib/route-table.c | 264 ++++++++++++++++++++------- > lib/route-table.h | 42 ++++- > lib/rtnetlink.c | 5 +- > tests/automake.mk | 5 +- > tests/system-library.at | 23 +++ > tests/system-userspace-testsuite.at | 2 + > tests/test-netlink-conntrack.c | 4 +- > tests/test-netlink-socket.c | 47 +++++ > tests/test-route-table.c | 43 +++++ > 15 files changed, 500 insertions(+), 89 deletions(-) > create mode 100644 tests/system-library.at > create mode 100644 tests/test-netlink-socket.c > create mode 100644 tests/test-route-table.c > > > base-commit: 2c7e2d58c30361de56dcae81cb31e399db1ad73c > -- > 2.47.0 > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev