Message ID | MEYP282MB3499A63F8F7F5D43FC66B88ACDCC9@MEYP282MB3499.AUSP282.PROD.OUTLOOK.COM |
---|---|
Headers | show |
Series | Fix ALB parameters type and value mismatch. | expand |
On 15/05/2022 08:09, miterv@outlook.com wrote: > From: Lin Huang <linhuang@ruijie.com.cn> > > This series fix ALB parameters type mismatch and set a hard limit > to rebalance_intvl. > > It also includes some self-tests. > > Changes since v2: > 1. Fix type mismatch int dpif-netdev.c. > > Changes since v1: > 1. Fix the commit message and formatting. > 2. Fix typo in unit tests. > > Lin Huang (2): > dpif-netdev: Fix ALB parameters type mismatch. > dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit. > > lib/dpif-netdev.c | 28 ++++++++++++++++------------ > tests/alb.at | 20 +++++++++++++++++++- > 2 files changed, 35 insertions(+), 13 deletions(-) > The changes lgtm, just need the checkpatch CI warnings fixed and I can Ack. fyi - you can check these before submission with the checkpatch script e.g. $ git format-patch -2 $ ./utilities/checkpatch.py *.patch thanks, Kevin.
Hi Kevin, Thanks for the review. It's very helpful to me. > -----Original Message----- > From: Kevin Traynor <ktraynor@redhat.com> > Sent: Tuesday, May 17, 2022 11:34 PM > To: miterv@outlook.com; ovs-dev@openvswitch.org > Cc: Lin Huang <linhuang@ruijie.com.cn> > Subject: Re: [PATCH v3 0/2] Fix ALB parameters type and value mismatch. > > On 15/05/2022 08:09, miterv@outlook.com wrote: > > From: Lin Huang <linhuang@ruijie.com.cn> > > > > This series fix ALB parameters type mismatch and set a hard limit > > to rebalance_intvl. > > > > It also includes some self-tests. > > > > Changes since v2: > > 1. Fix type mismatch int dpif-netdev.c. > > > > Changes since v1: > > 1. Fix the commit message and formatting. > > 2. Fix typo in unit tests. > > > > Lin Huang (2): > > dpif-netdev: Fix ALB parameters type mismatch. > > dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit. > > > > lib/dpif-netdev.c | 28 ++++++++++++++++------------ > > tests/alb.at | 20 +++++++++++++++++++- > > 2 files changed, 35 insertions(+), 13 deletions(-) > > > > The changes lgtm, just need the checkpatch CI warnings fixed and I can Ack. > > fyi - you can check these before submission with the checkpatch script e.g. > $ git format-patch -2 > $ ./utilities/checkpatch.py *.patch > > thanks, > Kevin.
From: Lin Huang <linhuang@ruijie.com.cn> This series fix ALB parameters type mismatch and set a hard limit to rebalance_intvl. It also includes some self-tests. Changes since v2: 1. Fix type mismatch int dpif-netdev.c. Changes since v1: 1. Fix the commit message and formatting. 2. Fix typo in unit tests. Lin Huang (2): dpif-netdev: Fix ALB parameters type mismatch. dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit. lib/dpif-netdev.c | 28 ++++++++++++++++------------ tests/alb.at | 20 +++++++++++++++++++- 2 files changed, 35 insertions(+), 13 deletions(-)