mbox series

[ovs-dev,0/3] classifier: Fix crash while setting flow table prefixes.

Message ID 20250516212521.733714-1-i.maximets@ovn.org
Headers show
Series classifier: Fix crash while setting flow table prefixes. | expand

Message

Ilya Maximets May 16, 2025, 9:25 p.m. UTC 
The second patch is the main fix, the last patch is a test for it.
Split this way for easier reviewing and testing.

The first patch is a small fix for the existing test function.

Ilya Maximets (3):
  tests: classifier: Fix the rule number check during trie verification.
  classifier: Fix race for prefix tree configuration.
  tests: classifier: Add a stress test for prefixes reconfiguration.

 lib/classifier.c        | 196 ++++++++++++++++++++--------------------
 lib/classifier.h        |  10 +-
 tests/classifier.at     |   5 +
 tests/test-classifier.c | 118 +++++++++++++++++++++---
 4 files changed, 212 insertions(+), 117 deletions(-)

Comments

Numan Siddique May 19, 2025, 3:25 a.m. UTC | #1 
On Fri, May 16, 2025 at 5:25 PM Ilya Maximets <i.maximets@ovn.org> wrote:
>
> The second patch is the main fix, the last patch is a test for it.
> Split this way for easier reviewing and testing.
>
> The first patch is a small fix for the existing test function.

Thanks Ilya for fixing the issue.  I'll test it out.

Thanks
Numan

>
> Ilya Maximets (3):
>   tests: classifier: Fix the rule number check during trie verification.
>   classifier: Fix race for prefix tree configuration.
>   tests: classifier: Add a stress test for prefixes reconfiguration.
>
>  lib/classifier.c        | 196 ++++++++++++++++++++--------------------
>  lib/classifier.h        |  10 +-
>  tests/classifier.at     |   5 +
>  tests/test-classifier.c | 118 +++++++++++++++++++++---
>  4 files changed, 212 insertions(+), 117 deletions(-)
>
> --
> 2.49.0
>
Ilya Maximets May 26, 2025, 5:33 p.m. UTC | #2 
On 5/16/25 11:25 PM, Ilya Maximets wrote:
> The second patch is the main fix, the last patch is a test for it.
> Split this way for easier reviewing and testing.
> 
> The first patch is a small fix for the existing test function.
> 
> Ilya Maximets (3):
>   tests: classifier: Fix the rule number check during trie verification.
>   classifier: Fix race for prefix tree configuration.
>   tests: classifier: Add a stress test for prefixes reconfiguration.
> 
>  lib/classifier.c        | 196 ++++++++++++++++++++--------------------
>  lib/classifier.h        |  10 +-
>  tests/classifier.at     |   5 +
>  tests/test-classifier.c | 118 +++++++++++++++++++++---
>  4 files changed, 212 insertions(+), 117 deletions(-)
> 

Thanks, Eelco and Numan!

I applied the set and backported to all supported branches down to 3.2.

While backporting below 3.5, I also backported the following small refactor
in order to avoid conflicts:
  3d6b048d84d9 ("classifier: Store n_indices between usage.")

Best regards, Ilya Maximets.